From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932528AbdJZOSD (ORCPT ); Thu, 26 Oct 2017 10:18:03 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:47588 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932422AbdJZORy (ORCPT ); Thu, 26 Oct 2017 10:17:54 -0400 Subject: Re: [PATCH 07/27] kexec_file: Disable at runtime if securelevel has been set From: Mimi Zohar To: joeyli Cc: David Howells , linux-security-module@vger.kernel.org, gnomes@lxorguk.ukuu.org.uk, linux-efi@vger.kernel.org, matthew.garrett@nebula.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, jforbes@redhat.com Date: Thu, 26 Oct 2017 10:17:43 -0400 In-Reply-To: <20171026074243.GM8550@linux-l9pv.suse> References: <150842463163.7923.11081723749106843698.stgit@warthog.procyon.org.uk> <150842468754.7923.10037578333644594134.stgit@warthog.procyon.org.uk> <1508774083.3639.124.camel@linux.vnet.ibm.com> <20171026074243.GM8550@linux-l9pv.suse> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 17102614-0016-0000-0000-000004FA376F X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17102614-0017-0000-0000-00002835B173 Message-Id: <1509027463.5886.26.camel@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-26_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1710260191 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-10-26 at 15:42 +0800, joeyli wrote: > Hi Mimi, > > Thank you for reviewing. > > On Mon, Oct 23, 2017 at 11:54:43AM -0400, Mimi Zohar wrote: > > On Thu, 2017-10-19 at 15:51 +0100, David Howells wrote: > > > From: Chun-Yi Lee > > > > > > When KEXEC_VERIFY_SIG is not enabled, kernel should not loads image > > > through kexec_file systemcall if securelevel has been set. > > > > The patch title and description needs to be updated to refer to > > lockdown, not securelevel. > > > > As previously mentioned the last time these patches were posted, this > > leaves out testing to see if the integrity subsystem is enabled. > > > > Commit 503ceaef8e2e "ima: define a set of appraisal rules requiring > > file signatures" was upstreamed.  An additional patch could force > > these rules to be added to the custom policy, if lockdown is enabled. > >  This and other patches in this series could then check to see if > > is_ima_appraise_enabled() is true. > > > > Mimi > > > > I have updated the patch title and description, and I also added > is_ima_appraise_enabled() as the following. Is it good to you? Yes, that works.  Thanks!  Remember is_ima_appraise_enabled() is dependent on the "ima: require secure_boot rules in lockdown mode" patch - http://kernsec.org/pipermail/linux-security-module-archive/201 7-October/003910.html. The IMA "secure_boot" policy can be specified on the boot command line as ima_policy="secure_boot".  It requires kernel modules, firmware, kexec kernel image and the IMA custom policy to be signed.  In lockdown mode, these rules are enabled by default and added to the custom policy. > On the other hand, I am not good on IMA. I have traced the code path > in kimage_file_prepare_segments(). Looks that the READING_KEXEC_IMAGE > doesn't show in selinux_kernel_read_file(). Where is the exact code > in IMA for checking the signature when loading crash kernel file? kernel_read_file_from_fd() calls the security_kernel_read_file() and security_kernel_post_read_file() hooks, which call ima_read_file() and ima_post_read_file() respectively. Mimi