From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752996AbdJaNC2 (ORCPT ); Tue, 31 Oct 2017 09:02:28 -0400 Received: from fllnx209.ext.ti.com ([198.47.19.16]:57629 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751050AbdJaNC0 (ORCPT ); Tue, 31 Oct 2017 09:02:26 -0400 From: Roger Quadros To: CC: , , , Roger Quadros , "# v4 . 13+" Subject: [PATCH] usb: dwc3: gadget: Fix .udc_set_speed() Date: Tue, 31 Oct 2017 15:01:44 +0200 Message-ID: <1509454904-4966-1-git-send-email-rogerq@ti.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org UDC core calls .udc_set_speed() with the speed parameter containing the maximum speed supported by the gadget function driver. This might very well be more or less than that supported by the dwc3 controller driver. Select the lesser of the 2 speeds so both are operating within limits. This fixes PHY Erratic errors and 2 second enumeration delay on TI's AM437x platforms. Fixes: 7d8d0639565f ("usb: dwc3: gadget: implement ->udc_set_speed()") Cc: # v4.13+ Reported-by: Dylan Howey Signed-off-by: Roger Quadros --- drivers/usb/dwc3/gadget.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index f064f15..9f27ec0 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -2008,6 +2008,8 @@ static void dwc3_gadget_set_speed(struct usb_gadget *g, unsigned long flags; u32 reg; + speed = min(g->max_speed, speed); + spin_lock_irqsave(&dwc->lock, flags); reg = dwc3_readl(dwc->regs, DWC3_DCFG); reg &= ~(DWC3_DCFG_SPEED_MASK); -- cheers, -roger Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki