From: Jerome Brunet <jbrunet@baylibre.com>
To: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
Linus Walleij <linus.walleij@linaro.org>,
Quentin Schulz <quentin.schulz@free-electrons.com>,
Kevin Hilman <khilman@baylibre.com>
Subject: Re: [PATCH v4 09/10] clk: add clk_rate_exclusive api
Date: Tue, 31 Oct 2017 18:29:54 +0100 [thread overview]
Message-ID: <1509470994.13838.28.camel@baylibre.com> (raw)
In-Reply-To: <150899557300.90597.9865127803541159465@resonance>
On Thu, 2017-10-26 at 07:26 +0200, Michael Turquette wrote:
> Hi Jerome,
>
> Quoting Jerome Brunet (2017-09-24 22:00:29)
> > @@ -1778,6 +1867,50 @@ int clk_set_rate(struct clk *clk, unsigned long rate)
> > EXPORT_SYMBOL_GPL(clk_set_rate);
> >
> > /**
> > + * clk_set_rate_exclusive - specify a new rate get exclusive control
> > + * @clk: the clk whose rate is being changed
> > + * @rate: the new rate for clk
> > + *
> > + * This is a combination of clk_set_rate() and clk_rate_exclusive_get()
> > + * within a critical section
> > + *
> > + * This can be used initially to ensure that at least 1 consumer is
> > + * statisfied when several consumers are competing for exclusivity over the
> > + * same clock provider.
>
> Please add the following here:
>
> Calls to clk_rate_exclusive_get() should be balanced with calls to
> clk_rate_exclusive_put().
Oh indeed !
I can do a resend with it or, if you prefer, you may directly amend the patch.
As you prefer
Thanks
>
> Otherwise looks good to me.
>
> Best regards,
> Mike
next prev parent reply other threads:[~2017-10-31 17:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-24 20:00 [PATCH v4 00/10] clk: implement clock rate protection mechanism Jerome Brunet
2017-09-24 20:00 ` [PATCH v4 01/10] clk: fix incorrect usage of ENOSYS Jerome Brunet
2017-09-24 20:00 ` [PATCH v4 02/10] clk: take the prepare lock out of clk_core_set_parent Jerome Brunet
2017-09-24 20:00 ` [PATCH v4 03/10] clk: add clk_core_set_phase_nolock function Jerome Brunet
2017-09-24 20:00 ` [PATCH v4 04/10] clk: rework calls to round and determine rate callbacks Jerome Brunet
2017-09-24 20:00 ` [PATCH v4 05/10] clk: use round rate to bail out early in set_rate Jerome Brunet
2017-09-24 20:00 ` [PATCH v4 06/10] clk: add clock protection mechanism to clk core Jerome Brunet
2017-09-24 20:00 ` [PATCH v4 07/10] clk: cosmetic changes to clk_summary debugfs entry Jerome Brunet
2017-09-24 20:00 ` [PATCH v4 08/10] clk: fix CLK_SET_RATE_GATE with clock rate protection Jerome Brunet
2017-09-24 20:00 ` [PATCH v4 09/10] clk: add clk_rate_exclusive api Jerome Brunet
2017-10-26 5:26 ` Michael Turquette
2017-10-31 17:29 ` Jerome Brunet [this message]
2017-10-31 17:32 ` Michael Turquette
2017-09-24 20:00 ` [PATCH v4 10/10] clk: fix set_rate_range when current rate is out of range Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509470994.13838.28.camel@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mturquette@baylibre.com \
--cc=quentin.schulz@free-electrons.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).