From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754004AbdKBLoK (ORCPT ); Thu, 2 Nov 2017 07:44:10 -0400 Received: from 8.mo4.mail-out.ovh.net ([188.165.33.112]:56846 "EHLO 8.mo4.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752632AbdKBLoI (ORCPT ); Thu, 2 Nov 2017 07:44:08 -0400 X-Greylist: delayed 1809 seconds by postgrey-1.27 at vger.kernel.org; Thu, 02 Nov 2017 07:44:08 EDT From: =?UTF-8?q?S=C3=A9bastien=20Szymanski?= To: linux-input@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Benjamin Tissoires , Jiri Kosina , Julien Boibessot , =?UTF-8?q?S=C3=A9bastien=20Szymanski?= Subject: [PATCH 2/3] HID: cp2112: add HIDRAW dependency Date: Thu, 2 Nov 2017 12:12:43 +0100 Message-Id: <1509621164-28830-2-git-send-email-sebastien.szymanski@armadeus.com> X-Mailer: git-send-email 2.7.3 In-Reply-To: <1509621164-28830-1-git-send-email-sebastien.szymanski@armadeus.com> References: <1509621164-28830-1-git-send-email-sebastien.szymanski@armadeus.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 18153447148597826630 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedttddrgeeigddvtdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Otherwise, with HIDRAW=n, the probe function crashes because of null dereference of hdev->hidraw. Fixes: 42cb6b35b9e6 ("HID: cp2112: use proper hidraw name with minor number") Signed-off-by: Sébastien Szymanski --- drivers/hid/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 374301f..8c7a0ce 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -230,7 +230,7 @@ config HID_CMEDIA config HID_CP2112 tristate "Silicon Labs CP2112 HID USB-to-SMBus Bridge support" - depends on USB_HID && I2C && GPIOLIB + depends on USB_HID && HIDRAW && I2C && GPIOLIB select GPIOLIB_IRQCHIP ---help--- Support for Silicon Labs CP2112 HID USB to SMBus Master Bridge. -- 2.7.3