From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751268AbdKFAS4 (ORCPT ); Sun, 5 Nov 2017 19:18:56 -0500 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:51644 "EHLO esa4.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751105AbdKFASy (ORCPT ); Sun, 5 Nov 2017 19:18:54 -0500 X-IronPort-AV: E=Sophos;i="5.44,350,1505750400"; d="scan'208";a="61160421" From: Bart Van Assche To: "keescook@chromium.org" , "Himanshu.Madhani@cavium.com" CC: "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "qla2xxx-upstream@cavium.com" , "martin.petersen@oracle.com" Subject: Re: [PATCH 0/4] scsi: qla2xxx: Convert timers to use timer_setup() Thread-Topic: [PATCH 0/4] scsi: qla2xxx: Convert timers to use timer_setup() Thread-Index: AQHTUnxqLuFMsym9kEu1r6DeAq4O46L/3oqAgAAI8YCABp0ugA== Date: Mon, 6 Nov 2017 00:18:50 +0000 Message-ID: <1509927529.8757.1.camel@wdc.com> References: <1509477229-62141-1-git-send-email-keescook@chromium.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [73.223.62.206] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1533;20:haJ2wx7GyXna36oUUvIH8CQOlUWywqSNo70yTTP6cYy4swCwt6ZDj9EOLUkq0IONIBMYBUJCD4eBymfJZd/Z9qSWxTyVu9cEVjb8m3HrkuQEfwlqpNKBZZaK+7/IyshP8Ni8+G+OB9/NsL3c8hsCtEkx17xsecuICwkUm+uQhMg= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 2635df3e-1cfe-451e-9e8a-08d524abf4da x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603199);SRVR:CY1PR0401MB1533; x-ms-traffictypediagnostic: CY1PR0401MB1533: wdcipoutbound: EOP-TRUE x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3231021)(100000703101)(100105400095)(3002001)(93006095)(93001095)(10201501046)(6055026)(6041248)(20161123564025)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR0401MB1533;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR0401MB1533; x-forefront-prvs: 048396AFA0 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(346002)(39860400002)(376002)(24454002)(189002)(199003)(377424004)(86362001)(2906002)(8676002)(6436002)(66066001)(14454004)(305945005)(36756003)(229853002)(2501003)(99286004)(189998001)(3660700001)(8936002)(3280700002)(25786009)(97736004)(6486002)(77096006)(81156014)(81166006)(6506006)(54356999)(76176999)(50986999)(72206003)(53546010)(7736002)(103116003)(4326008)(6116002)(102836003)(3846002)(5660300001)(101416001)(2900100001)(105586002)(6512007)(478600001)(316002)(33646002)(54906003)(110136005)(2950100002)(53936002)(106356001)(6246003)(68736007);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1533;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <3E1A26FD83F09144A7D80CE7883CCB94@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2635df3e-1cfe-451e-9e8a-08d524abf4da X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Nov 2017 00:18:50.7362 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1533 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vA60J1uY003084 On Wed, 2017-11-01 at 19:18 +0000, Madhani, Himanshu wrote: > Hi Kees, > > > On Nov 1, 2017, at 11:46 AM, Kees Cook wrote: > > > > On Tue, Oct 31, 2017 at 12:13 PM, Kees Cook wrote: > > > This breaks out the logical steps to convert the qla2xxx timers: > > > > > > 1) init_timer() -> setup_timer() > > > 2) refactor qla2x00_start_timer() to not pass callback as argument > > > 3) qla2x00_timer() to use timer_setup() > > > 4) qla2x00_sp_timeout() to use timer_setup() > > > > > > The resulting diff is identical to the patch that appears to lock up > > > the driver. This should help identify which step causes this behavior. > > > > Hi, just curious if there's been any progress on debugging the issue > > you saw with this series? > > Sorry for delay. I will test this series later today and post update. Hello Himanshu and Kees, The qla2xxx driver does not crash if apply these four patches on kernel v4.14-rc8 and load the qla2xxx driver on my test setup. Point-to-point mode seems broken again but I don't think that's related to this patch series. Bart.