From: Wen Yang <wen.yang99@zte.com.cn>
To: tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, wen.yang99@zte.com.cn,
jiang.biao2@zte.com.cn, zhong.weidong@zte.com.cn
Subject: [PATCH] irq/proc: throw error number when irq_set_affinity fails in write_irq_affinity()
Date: Wed, 8 Nov 2017 09:55:03 +0800 [thread overview]
Message-ID: <1510106103-184761-1-git-send-email-wen.yang99@zte.com.cn> (raw)
When irq_set_affinity() fails in write_irq_affinity(), it'll not throw error number like,
https://bugzilla.kernel.org/show_bug.cgi?id=197795
This patch should fix that.
Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Reviewed-by: Jiang Biao <jiang.biao2@zte.com.cn>
---
kernel/irq/proc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/kernel/irq/proc.c b/kernel/irq/proc.c
index 7f9642a..574d41c 100644
--- a/kernel/irq/proc.c
+++ b/kernel/irq/proc.c
@@ -154,8 +154,9 @@ static ssize_t write_irq_affinity(int type, struct file *file,
*/
err = irq_select_affinity_usr(irq) ? -EINVAL : count;
} else {
- irq_set_affinity(irq, new_value);
- err = count;
+ err = irq_set_affinity(irq, new_value);
+ if(!err)
+ err = count;
}
free_cpumask:
--
1.8.3.1
next reply other threads:[~2017-11-08 1:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 1:55 Wen Yang [this message]
2017-11-12 22:31 ` [tip:irq/core] genirq/proc: Return proper error code when irq_set_affinity() fails tip-bot for Wen Yaxng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510106103-184761-1-git-send-email-wen.yang99@zte.com.cn \
--to=wen.yang99@zte.com.cn \
--cc=jiang.biao2@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=zhong.weidong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).