From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751958AbdKHRtR (ORCPT ); Wed, 8 Nov 2017 12:49:17 -0500 Received: from smtprelay0159.hostedemail.com ([216.40.44.159]:41651 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751344AbdKHRtP (ORCPT ); Wed, 8 Nov 2017 12:49:15 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:3872:4250:4321:4605:5007:10004:10400:10848:11026:11232:11658:11914:12294:12296:12438:12740:12760:12895:13069:13311:13357:13439:14096:14097:14659:14721:21080:21627:30036:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: jar22_33719736d162e X-Filterd-Recvd-Size: 2266 Message-ID: <1510163351.15768.29.camel@perches.com> Subject: Re: [PATCH net-next 4/6] net: dsa: remove trans argument from vlan ops From: Joe Perches To: Vivien Didelot , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli , Andrew Lunn Date: Wed, 08 Nov 2017 09:49:11 -0800 In-Reply-To: <20171108171917.5965-5-vivien.didelot@savoirfairelinux.com> References: <20171108171917.5965-1-vivien.didelot@savoirfairelinux.com> <20171108171917.5965-5-vivien.didelot@savoirfairelinux.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-11-08 at 12:19 -0500, Vivien Didelot wrote: > The DSA switch VLAN ops pass the switchdev_trans structure down to the > drivers, but no one is using them and they aren't supposed to anyway. [] > diff --git a/include/net/dsa.h b/include/net/dsa.h [] > @@ -410,12 +410,10 @@ struct dsa_switch_ops { > */ > int (*port_vlan_filtering)(struct dsa_switch *ds, int port, > bool vlan_filtering); > - int (*port_vlan_prepare)(struct dsa_switch *ds, int port, > - const struct switchdev_obj_port_vlan *vlan, > - struct switchdev_trans *trans); > - void (*port_vlan_add)(struct dsa_switch *ds, int port, > - const struct switchdev_obj_port_vlan *vlan, > - struct switchdev_trans *trans); > + int (*port_vlan_prepare)(struct dsa_switch *ds, int port, > + const struct switchdev_obj_port_vlan *vlan); > + void (*port_vlan_add)(struct dsa_switch *ds, int port, > + const struct switchdev_obj_port_vlan *vlan); > int (*port_vlan_del)(struct dsa_switch *ds, int port, > const struct switchdev_obj_port_vlan *vlan); I think this bit is slightly worse. Mixing alignment styles seems odd. I think it's better to either align all the (*func) uses on a tabstop or none of them.