From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755734AbdKMVOk (ORCPT <rfc822;w@1wt.eu>);
        Mon, 13 Nov 2017 16:14:40 -0500
Received: from mx1.redhat.com ([209.132.183.28]:39404 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754364AbdKMVOi (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 13 Nov 2017 16:14:38 -0500
Message-ID: <1510607676.3735.37.camel@redhat.com>
Subject: Re: [PATCH] infiniband: avoid uninitialized variable warning in
 create_udata
From: Doug Ledford <dledford@redhat.com>
To: Leon Romanovsky <leon@kernel.org>, Arnd Bergmann <arnd@arndb.de>
Cc: Christoph Hellwig <hch@lst.de>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Matan Barak <matanb@mellanox.com>, Yishai Hadas <yishaih@mellanox.com>,
        Sean Hefty <sean.hefty@intel.com>,
        Dasaratharaman Chandramouli 
        <dasaratharaman.chandramouli@intel.com>,
        linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Mon, 13 Nov 2017 16:14:36 -0500
In-Reply-To: <20171111092105.GU18825@mtr-leonro.local>
References: <20171110221053.3549147-1-arnd@arndb.de>
         <20171111092105.GU18825@mtr-leonro.local>
Organization: Red Hat, Inc.
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-U+NHCnYo+NQwgQ1cc7rY"
Mime-Version: 1.0
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 13 Nov 2017 21:14:38 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--=-U+NHCnYo+NQwgQ1cc7rY
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, 2017-11-11 at 11:21 +0200, Leon Romanovsky wrote:
> On Fri, Nov 10, 2017 at 11:10:31PM +0100, Arnd Bergmann wrote:
> > As Dan pointed out, the rework I did makes it harder for smatch and oth=
er
> > static checkers to figure out what is going on with the uninitialized
> > pointers.
> >=20
> > By open-coding the call in create_udata(), we make it more readable for
> > both humans and tools.
> >=20
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Fixes: 12f727721eee ("IB/uverbs: clean up INIT_UDATA_BUF_OR_NULL usage"=
)
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> >  drivers/infiniband/core/uverbs_std_types.c | 21 ++++++++++-----------
> >  1 file changed, 10 insertions(+), 11 deletions(-)
> >=20
>=20
> Thanks,
> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>

Thanks, applied.

--=20
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint =3D AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD
--=-U+NHCnYo+NQwgQ1cc7rY
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEErmsb2hIrI7QmWxJ0uCajMw5XL90FAloKCzwACgkQuCajMw5X
L92kaw//cthcnBeEBRHPiYG6tjOlywNfyXYifkwYxUXEIOd4MUwWB83+AKceHJUr
Vxng/spTgfL/VDhF7HxnL71QXGgVtWJGeQoREulhnrPSjWwMGll6MsDMlyF4sL3e
hsn4A5iPAPIYmwXTgJfaJ23MRHUzykWl6u/Err98PL2d9ql2/rJdfT6BG/oSHVOv
oY+vhd/PXkHDgGGZb44Ekr2rzNhNK7v+Vt03w/BGkw069qnUUjcknSC1FKtKiG6a
zH02PU7CEu5svETByMDt8Q27MtioOxY/QHPJjxivom3vE3rQJemYSLuhuFBZ+y5f
0sA/wIHft9POyIqIdwAdDlNSZEPbxr1401vHMN8ylO9ysgyWzvUZux6vEoP3o6L4
UUmdE6JSbLp5CQ1Z+rMQS/vyH3ysBSwYvdAbEQxyAxajny0JFNpLTuhdKFw84Hje
TB6ov/CiZqHZ05qGugt3vwZF9+J5RTvssPaxkeezhGzXC/XsGrXoo35+gFsq66Uy
jdnjM5Io7BhyFijX+9J8PLRkIlH0sCYYLxZc6/+TJGnC4ipzrFsh6ZYBl087Yt2W
BEXiQIHuL3vi792hpsRzZnPo5ei1/gheu4OD3SUyi72JzIQZ7l8BUI3+0p2Kdess
hEb25adv7UeJWu19MaKcaZMsYbErh3L85c5WAUOjBTb17kIMEeA=
=Smde
-----END PGP SIGNATURE-----

--=-U+NHCnYo+NQwgQ1cc7rY--