From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754742AbdKNMsG (ORCPT ); Tue, 14 Nov 2017 07:48:06 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:45196 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754360AbdKNMr5 (ORCPT ); Tue, 14 Nov 2017 07:47:57 -0500 Subject: Re: [PATCH v3 2/2] perf/bench/numa: Handle discontiguous/sparse numa nodes From: Satheesh Rajendran To: "Naveen N. Rao" Cc: acme@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, srikar@linux.vnet.ibm.com, bala24@linux.vnet.ibm.com In-Reply-To: <20171031151658.clq6qmdfw3gj6afg@naverao1-tp.localdomain> References: <67b88aa2de6dd199d57bacdecf35d26958780feb.1503310062.git.sathnaga@linux.vnet.ibm.com> <20171031151658.clq6qmdfw3gj6afg@naverao1-tp.localdomain> Content-Type: text/plain; charset="UTF-8" Date: Tue, 14 Nov 2017 18:16:02 +0530 Mime-Version: 1.0 X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 17111412-0024-0000-0000-000002F27E4D X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008065; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000240; SDB=6.00945732; UDB=6.00477315; IPR=6.00726029; BA=6.00005689; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00018010; XFM=3.00000015; UTC=2017-11-14 12:47:56 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17111412-0025-0000-0000-000046073CC6 Message-Id: <1510663562.24275.38.camel@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-14_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1711140175 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Naveen, On Tue, 2017-10-31 at 20:46 +0530, Naveen N. Rao wrote: >  > >   } > >   BUG_ON(nr_min > nr_max); > > - > Looks like an un-necessary change there. > > - Naveen > I had hit with this compilation error, so had to move the initialization above. Please advice. Thanks.   CC       bench/numa.o bench/numa.c: In function ‘calc_convergence’: bench/numa.c:1035:3: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]    int processes = count_node_processes(node);    ^ cc1: all warnings being treated as errors mv: cannot stat ‘bench/.numa.o.tmp’: No such file or directory make[4]: *** [bench/numa.o] Error 1 make[3]: *** [bench] Error 2 make[2]: *** [perf-in.o] Error 2 make[1]: *** [sub-make] Error 2 make: *** [all] Error 2 Regards, -Satheesh. > > > >   BUG_ON(sum > g->p.nr_tasks); > > > >   if (0 && (sum < g->p.nr_tasks)) @@ -1027,8 +1029,9 @@ static void calc_convergence(double