From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261407AbUKINzm (ORCPT ); Tue, 9 Nov 2004 08:55:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261419AbUKINzm (ORCPT ); Tue, 9 Nov 2004 08:55:42 -0500 Received: from mx1.redhat.com ([66.187.233.31]:52688 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S261407AbUKINzh (ORCPT ); Tue, 9 Nov 2004 08:55:37 -0500 From: David Howells In-Reply-To: <20041109125747.GB4867@infradead.org> References: <20041109125747.GB4867@infradead.org> <20040401020550.GG3150@beast> <200411081434.iA8EYKn7023613@warthog.cambridge.redhat.com> To: Christoph Hellwig Cc: torvalds@osdl.org, akpm@osdl.org, davidm@snapgear.com, linux-kernel@vger.kernel.org, uclinux-dev@uclinux.org Subject: Re: [PATCH 17/20] FRV: Better mmap support in uClinux User-Agent: EMH/1.14.1 SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 Emacs/21.3 (i386-redhat-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Date: Tue, 09 Nov 2004 13:55:26 +0000 Message-ID: <15110.1100008526@redhat.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > > +/* list of shareable VMAs */ > > +LIST_HEAD(nommu_vma_list); > > +DECLARE_RWSEM(nommu_vma_sem); > > As I told you this absolutely should be static. Yes, you did. I ignored you. You also said that I shouldn't put any proc stuff in mm/. David