From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751784AbdKXHRI (ORCPT ); Fri, 24 Nov 2017 02:17:08 -0500 Received: from smtprelay0193.hostedemail.com ([216.40.44.193]:40447 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751507AbdKXHRH (ORCPT ); Fri, 24 Nov 2017 02:17:07 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:800:960:966:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1714:1730:1747:1777:1792:2196:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3865:3867:3868:3870:3871:3872:4250:4321:4385:5007:6119:7875:7903:10004:10400:10848:11026:11232:11658:11914:12043:12048:12296:12438:12555:12740:12760:12895:12986:13069:13311:13357:13439:14181:14659:14721:21080:21627:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: love83_780d91e772e17 X-Filterd-Recvd-Size: 1839 Message-ID: <1511507823.8230.8.camel@perches.com> Subject: Re: [PATCH 1/1] Input: ims-pcu - fix typo in an error log From: Joe Perches To: Zhen Lei , Dmitry Torokhov , linux-input , linux-kernel Cc: Hanjun Guo , Libin , Kefeng Wang Date: Thu, 23 Nov 2017 23:17:03 -0800 In-Reply-To: <1511506772-21412-1-git-send-email-thunder.leizhen@huawei.com> References: <1511506772-21412-1-git-send-email-thunder.leizhen@huawei.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-11-24 at 14:59 +0800, Zhen Lei wrote: > Tiny typo fixed in an error log. > > I found this when I backported the CVE-2017-16645 patch: > ea04efee7635 ("Input: ims-psu - check if CDC union descriptor is sane") > > Signed-off-by: Zhen Lei > --- > drivers/input/misc/ims-pcu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/misc/ims-pcu.c b/drivers/input/misc/ims-pcu.c [] > @@ -1651,7 +1651,7 @@ static void ims_pcu_buffers_free(struct ims_pcu *pcu) > return union_desc; > > dev_err(&intf->dev, > - "Union descriptor to short (%d vs %zd\n)", > + "Union descriptor too short (%d vs %zd\n)", And this format is incorrect too. It should be: + "Union descriptor too short (%d vs %zd)\n", with the close parenthesis before the newline, not after.