From: Johannes Berg <johannes@sipsolutions.net>
To: Florian Fainelli <f.fainelli@gmail.com>,
Arend van Spriel <arend.vanspriel@broadcom.com>,
open list <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
David Howells <dhowells@redhat.com>,
linux-wireless@vger.kernel.org
Subject: Re: kernel BUG at crypto/asymmetric_keys/public_key.c:80
Date: Fri, 24 Nov 2017 08:56:28 +0100 [thread overview]
Message-ID: <1511510188.2841.7.camel@sipsolutions.net> (raw)
In-Reply-To: <46fde28f-8f97-841e-d00a-399a40b3a2e7@gmail.com> (sfid-20171123_184803_677305_35FC2C0E)
On Thu, 2017-11-23 at 09:47 -0800, Florian Fainelli wrote:
> Absolutely, please find it enclosed.
Thanks.
This is a bit odd. I didn't think the most likely reason is that you
have
CONFIG_CRYPTO_SHA256=m
but everything else built-in. Thus, when loading the certificate,
there's no way to calculate the digest since that requires sha-256,
hence
BUG_ON(!sig->digest);
If you make CONFIG_CRYPTO_SHA256=y then it should go away.
I guess I'll do this:
diff --git a/net/wireless/Kconfig b/net/wireless/Kconfig
index da91bb547db3..1abcc4fc4df1 100644
--- a/net/wireless/Kconfig
+++ b/net/wireless/Kconfig
@@ -20,6 +20,10 @@ config CFG80211
tristate "cfg80211 - wireless configuration API"
depends on RFKILL || !RFKILL
select FW_LOADER
+ # may need to update this when certificates are changed and are
+ # using a different algorithm, though right now they shouldn't
+ # (this is here rather than below to allow it to be a module)
+ select CRYPTO_SHA256 if CFG80211_USE_KERNEL_REGDB_KEYS
---help---
cfg80211 is the Linux wireless LAN (802.11) configuration API.
Enable this if you have a wireless device.
@@ -113,6 +117,9 @@ config CFG80211_EXTRA_REGDB_KEYDIR
certificates like in the kernel sources (net/wireless/certs/)
that shall be accepted for a signed regulatory database.
+ Note that you need to also select the correct CRYPTO_<hash> modules
+ for your certificates, and if cfg80211 is built-in they also must be.
+
config CFG80211_REG_CELLULAR_HINTS
bool "cfg80211 regulatory support for cellular base station hints"
depends on CFG80211_CERTIFICATION_ONUS
Can you try if that fixes your config for you?
johannes
prev parent reply other threads:[~2017-11-24 7:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 17:43 kernel BUG at crypto/asymmetric_keys/public_key.c:80 Florian Fainelli
2017-11-22 18:29 ` Arend van Spriel
2017-11-22 18:42 ` Johannes Berg
2017-11-22 23:07 ` Florian Fainelli
2017-11-23 14:24 ` Johannes Berg
2017-11-23 17:47 ` Florian Fainelli
2017-11-24 7:56 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511510188.2841.7.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend.vanspriel@broadcom.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=f.fainelli@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).