From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753820AbdKXScz (ORCPT ); Fri, 24 Nov 2017 13:32:55 -0500 Received: from mail-pl0-f53.google.com ([209.85.160.53]:45561 "EHLO mail-pl0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750731AbdKXScx (ORCPT ); Fri, 24 Nov 2017 13:32:53 -0500 X-Google-Smtp-Source: AGs4zMamobpBsv4t0qARDcVQm18SK4uHaTFzfHxZjKUD8i4ys+b9tN2xWnsu99UNxtM+xWpubtYwHQ== Message-ID: <1511548369.16595.4.camel@gmail.com> Subject: Re: [PATCH] net-sysfs: export gso_max_size attribute From: Eric Dumazet To: David Ahern , Solio Sarabia , netdev@vger.kernel.org, davem@daveloft.net, stephen@networkplumber.org Cc: kys@microsoft.com, shiny.sebastian@intel.com, linux-kernel@vger.kernel.org Date: Fri, 24 Nov 2017 10:32:49 -0800 In-Reply-To: <338121b9-5e71-be85-7faf-02dbba070df3@gmail.com> References: <1511397041-27994-1-git-send-email-solio.sarabia@intel.com> <338121b9-5e71-be85-7faf-02dbba070df3@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-11-24 at 10:14 -0700, David Ahern wrote: > On 11/22/17 5:30 PM, Solio Sarabia wrote: > > The netdevice gso_max_size is exposed to allow users fine-control > > on > > systems with multiple NICs with different GSO buffer sizes, and > > where > > the virtual devices like bridge and veth, need to be aware of the > > GSO > > size of the underlying devices. > > > > In a virtualized environment, setting the right GSO sizes for > > physical > > and virtual devices makes all TSO work to be on physical NIC, > > improving > > throughput and reducing CPU util. If virtual devices send buffers > > greater than what NIC supports, it forces host to do TSO for > > buffers > > exceeding the limit, increasing CPU utilization in host. > > > > Suggested-by: Shiny Sebastian > > Signed-off-by: Solio Sarabia > > --- > > This should be added to rtnetlink rather than sysfs. This is already exposed by rtnetlink [1] Please lets not add yet another net-sysfs knob. [1] c70ce028e834f8e51306217dbdbd441d851c64d3 net/rtnetlink: add IFLA_GSO_MAX_SEGS and IFLA_GSO_MAX_SIZE attributes