From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751731AbdK0LY4 (ORCPT ); Mon, 27 Nov 2017 06:24:56 -0500 Received: from s3.sipsolutions.net ([144.76.63.242]:35550 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751292AbdK0LYz (ORCPT ); Mon, 27 Nov 2017 06:24:55 -0500 Message-ID: <1511781888.5456.1.camel@sipsolutions.net> Subject: Re: [PATCH v3] staging: rtl8188eu: Fix private WEXT IOCTL calls From: Johannes Berg To: ishraq.i.ashraf@gmail.com, gregkh@linuxfoundation.org Cc: himanshujha199640@gmail.com, goudapatilk@gmail.com, insafonov@gmail.com, dan.carpenter@oracle.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Mon, 27 Nov 2017 12:24:48 +0100 In-Reply-To: <1511634581-997-1-git-send-email-ishraq.i.ashraf@gmail.com> (sfid-20171125_192950_828290_FF021A61) References: <1511400546-10875-1-git-send-email-ishraq.i.ashraf@gmail.com> <1511634581-997-1-git-send-email-ishraq.i.ashraf@gmail.com> (sfid-20171125_192950_828290_FF021A61) Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.0-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In addition to what Dan said, > +static iw_handler rtw_handlers_private[] = { > + NULL, /* Empty */ > + rtw_hostapd_sta_flush_pvt, /* RTL871X_HOSTAPD_FLUSH */ > + rtw_add_sta_pvt, /* RTL871X_HOSTAPD_ADD_STA */ > + rtw_del_sta_pvt, /* RTL871X_HOSTAPD_REMOVE_STA */ > + rtw_ioctl_get_sta_data_pvt, /* RTL871X_HOSTAPD_GET_INFO_STA */ > + rtw_get_sta_wpaie_pvt, /* RTL871X_HOSTAPD_GET_WPAIE_STA */ > + rtw_set_encryption_pvt, /* RTL871X_SET_ENCRYPTION */ > + NULL, /* RTL871X_GET_ENCRYPTION */ > + NULL, /* RTL871X_HOSTAPD_SET_FLAGS_STA */ > + NULL, /* RTL871X_HOSTAPD_GET_RID */ > + NULL, /* RTL871X_HOSTAPD_SET_RID */ > + NULL, /* RTL871X_HOSTAPD_SET_ASSOC_AP_ADDR */ > + NULL, /* RTL871X_HOSTAPD_SET_GENERIC_ELEMENT */ > + NULL, /* RTL871X_HOSTAPD_MLME */ > + NULL, /* RTL871X_HOSTAPD_SCAN_REQ */ > + NULL, /* RTL871X_HOSTAPD_STA_CLEAR_STATS */ > + rtw_set_beacon_pvt, /* RTL871X_HOSTAPD_SET_BEACON */ > + rtw_set_wps_beacon_pvt, /* RTL871X_HOSTAPD_SET_WPS_BEACON */ > + rtw_set_wps_probe_resp_pvt, /* RTL871X_HOSTAPD_SET_WPS_PROBE_RESP */ > + rtw_set_wps_assoc_resp_pvt, /* RTL871X_HOSTAPD_SET_WPS_ASSOC_RESP */ > + rtw_set_hidden_ssid_pvt, /* RTL871X_HOSTAPD_SET_HIDDEN_SSID */ > + rtw_ioctl_set_macaddr_acl_pvt, /* RTL871X_HOSTAPD_SET_MACADDR_ACL */ > + rtw_ioctl_acl_add_sta_pvt, /* RTL871X_HOSTAPD_ACL_ADD_STA */ > + rtw_ioctl_acl_remove_sta_pvt, /* RTL871X_HOSTAPD_ACL_REMOVE_STA */ > +}; > You should probably use array element initializers: static ... [] = { [RTL871X_HOSTAPD_FLUSH] = rtw_hostapd_sta_flush_pvt, ... }; johannes