From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752338AbdK1JvD (ORCPT ); Tue, 28 Nov 2017 04:51:03 -0500 Received: from mail-ve1eur01on0075.outbound.protection.outlook.com ([104.47.1.75]:19136 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751355AbdK1Jts (ORCPT ); Tue, 28 Nov 2017 04:49:48 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yossefe@mellanox.com; From: yossefe@mellanox.com To: "David S. Miller" , Steffen Klassert , Herbert Xu , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: borisp@mellanox.com, kliteyn@mellanox.com, yossiku@mellanox.com, Yossef Efraim Subject: [PATCH net-next 2/3] xfrm: Fix xfrm_dev_state_add to fail for unsupported HW SA option Date: Tue, 28 Nov 2017 11:49:29 +0200 Message-Id: <1511862571-3494-2-git-send-email-yossefe@mellanox.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1511862571-3494-1-git-send-email-yossefe@mellanox.com> References: <1511862571-3494-1-git-send-email-yossefe@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [82.166.227.17] X-ClientProxiedBy: AM5PR0102CA0002.eurprd01.prod.exchangelabs.com (2603:10a6:206::15) To AM0PR0502MB3745.eurprd05.prod.outlook.com (2603:10a6:208:1e::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: a7b1c196-5d32-445a-b698-08d536455b14 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603258);SRVR:AM0PR0502MB3745; X-Microsoft-Exchange-Diagnostics: 1;AM0PR0502MB3745;3:B3WLYYZblifjXrMnQJ/aXoQv3/1TjA/jUnAEbOwH5EKs/YQgPTtLX65a82OYddKrWQqsa4kzajBK+fiQiXS9Fq3epI2RLx/av/LEKuCyWaNeJSjst0fsnCvulFt5mE84sfTy66fzKziVsw0FQM1+9R9+Xyd/5EZ3sACAHfSQxVit+7qipxSOFmLQ8yBcJruUkOpqAwezofPXbyrbOsEAHHGnR+FjbVzR/W3XnI3++CHxe1gyG9sYYpnHBBVPcY1q;25:zMwpdH2oYEV1s/a+QEAx0jZw4F0R5C3BOFfLMt0QNGFNewRSeZSL8c/hzlVDVZgAfqqjKKQUXqk8SVFKmGXhCYx/cqBoYzT88VbKBy+QoP16xpSzd4p5rLew7E9YLXWKjk9YJqOM0TQsHFEvzc2JUaHfxYwfZcZWGMIXMZb0wGN8Rf9osbIIlqjjQqPWbRPAyn3oIKnokczv/h9EYqyw69Bh8BL6bHpTcpJ8gtM/22is0+40A43e/X7aAi1U+fIgXk/jyViKKahWuX7T24Rrknc+qxo8Mv7+G01TndMwYvA5/Tm4ZmduxCjtV6sQQJrJxL2+g3u2VW0DY+8h2GUsvA==;31:7IGkBF2H7nqdwlysZAKp/IEG/cyhIgh1OrBknT7xA5/c9/bHgDzJfaCoEXj27z66v7sca/FUezouWCehECFo0aEgzcOezA1Kqy2tGmWGY+pncQWO4+pH/NTY5DzN+kYIx2ku0fj1EaIKiDCkfPIjzrx4hI9S26efvjmh1qTXu43xk+8Jk+Xn9eFlQYxMn5JCYEmN14pTnV+JBu42KKbiKpbbeabz3Cm8VG1g0OHfwnE= X-MS-TrafficTypeDiagnostic: AM0PR0502MB3745: X-Microsoft-Exchange-Diagnostics: 1;AM0PR0502MB3745;20:5p8PYHIn5ZBwGFwAmvVRiDtQG/Emx7AfkiKTa9KpR519C7vRHpJVL6C8COKYbFdHVkUVWmVWSzKSfStCayZwOPcRf9Dr19J88Mi5Qh30MeBt7bG/Pfbd52IP8mjciQfhek0ZjDPfNaqpbsV1xK0qNcAcHdCFAL3Azqa+jIwZUpvJw6tvRdTMLmA1IZ2gW+12jThLtu1qQr9YmnLsxe6hhZeSfBXjVaSPCuKIvPLrmVwqASlG7i0wMVdMEUJI38JxTpUSPRDWub1AuOU5SO9aL994WI4TzdO0pTbnnuFRg4O8/KOMWYZJjtaJDiF5gXtatXcTltcHvT/vBo4IkRtbuZJ6GJbD621ZqRb2t6GFS5KkcuFjg9Lut5UfqmYi6hjEhBbvCx0b6Pxxs40l1bZa+jsPfJ7RMCPxxnab5ChtD0u/fW05WDUgb6V3VxBlLq4SPWmx08tt8DKK02/mngXt867xP31Q2G56ypT47uF5c5Pz8p/adP7/aL4iDEJc7yGU;4:Z1V5arrHLD7F3ZgX7typxCMaLLARiH03p1CJWPq9Xx8FuP9wZin8pOXZqog1KaJscH8mT8rZH6LLDOabm5B1IbZIeD+LQdTqMjgL52O5jxm04y+3vavBra8xwSjalrDw85/kG3FEkFMjnB8RTL8TmcdmUUhHzNAvPZNQTpZ1kGfx9cT9E02vVK1Hop6YATQ6fY3eton3xZmMN+Wcx2DzhcW0hDRRFqa/XTTmtFO4jhntrEcdFEozV/yRf5ipWCQFRFxqqtOseVKdrfHQZMGF3g== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(3002001)(3231022)(10201501046)(93006095)(93001095)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(20161123558100)(6072148)(201708071742011);SRVR:AM0PR0502MB3745;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:AM0PR0502MB3745; X-Forefront-PRVS: 0505147DDB X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(366004)(376002)(346002)(199003)(189002)(66066001)(4326008)(68736007)(53936002)(6512007)(107886003)(9686003)(48376002)(50466002)(85782001)(6116002)(189998001)(86362001)(47776003)(3846002)(36756003)(52116002)(97736004)(51416003)(81166006)(81156014)(8676002)(8936002)(5660300001)(478600001)(316002)(33646002)(2950100002)(50226002)(7736002)(16526018)(6666003)(101416001)(110136005)(16586007)(106356001)(105586002)(2906002)(25786009)(76176999)(50986999)(305945005)(6486002)(85772001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR0502MB3745;H:dev-l-vrt-187.mtl.labs.mlnx;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;AM0PR0502MB3745;23:KoV29wSJN1ZQFezX/HMqqTUplJX2HFduoXIFkFH?= =?us-ascii?Q?OHnH2LsbdE3D+crDfgwJNuVK1A53MKb3LOQYSIoKAtoGkt4xza0AJ1WVBt9R?= =?us-ascii?Q?HeJF2WeiGERw6DKUnFibrdzVifxxRiS1dSn0o3QdYwNJotJ47Kz7RUlthwsx?= =?us-ascii?Q?sWleS0c//bfFCcv4JcUYAoBKiDTPn7JhVCkHY42s+qlmSLQ78WTmXHISFZ4X?= =?us-ascii?Q?cESRMBWVcpGQBr7vqMermUQaix/cXrsN1fkWOeq3rSH0/UA6pkMBsf7c/lvC?= =?us-ascii?Q?Vy5OfuVU42bRf4lg5/IIktVOMXkc8+eLPBRJvCEYyPG73hOtlJngR0TWVWh/?= =?us-ascii?Q?tuiaYV0UZ2alf/4iZd7YwrJGURLjFnodQFE2JoQrki6Vm/rxB6+I0uH1kAo9?= =?us-ascii?Q?zz/rH2HEU30lkvFxIVTkCDw/hy3wbfsMQuyGHVlt614DbrOXR6Bv58ZXrhQn?= =?us-ascii?Q?YGeDy0MqkQ7GucZ2CQF3eZt7Wi+nKUj/JEQNElm5piBcIXggnmrEDABbnNpf?= =?us-ascii?Q?WlimttcNUrKqcU/PRHmNieGPutHwFzmjiTXmaCiJFcCI/1lglqaXLsm/jfCA?= =?us-ascii?Q?ZhXe7C15OinIlQurpNNXxhsda5lX2xnH2dFQi9VcrOQNzf7LQ9kPneYsyB+k?= =?us-ascii?Q?wp/VAzL5dwRLBEepXeDSUvzaKAcCGMCZWtXUww/XkQfIJ+t8YtTz/y3AnY4N?= =?us-ascii?Q?JNjl4HtxhZEGH3V4+Wyc4WfsAzwIYr+ZEQ2TY5xuV0sEqdoQqFKHi4B3/5XD?= =?us-ascii?Q?tMtTRzXkSt2HfHOP99js6GUFdjDsGRh1YOoa7xdKfvw11qT6pvnnzWt8Q4mJ?= =?us-ascii?Q?YCr2HkE4DMABFLhpwtBWwGcZd/cmwf4JoH7NNuTnvlokvt1zY4cLtuFaPMMD?= =?us-ascii?Q?s4A7LRluY3UiYQejuw5qIIkK/xUL5j5sOsPshltJIEpckjSdYlFoSW7Dlj7R?= =?us-ascii?Q?bUpPc18EniNIOYijFDuJ3HKuo8uCqCcWYsbjUJD7ap0X3nwldl/rpmz4TyDQ?= =?us-ascii?Q?wu2yqQ7kI0HRSby30W2Lm0/ULFp+RkwM8F6/v0wCfaIzY6JNExf3T3F7h1qZ?= =?us-ascii?Q?bzCrQZ1tmjgtAxomfjZ5Gcssf8cdU+NBGcGxGSe8MGoz93IG0ELN5taGm4pA?= =?us-ascii?Q?IJab6oqvnWM3rm6MKEdM+QPd6DnCOOi6E/cUM7nPdzVwIwqdv3/EPYwh+8ue?= =?us-ascii?Q?dWUsSfO/CXCf0Hi8=3D?= X-Microsoft-Exchange-Diagnostics: 1;AM0PR0502MB3745;6:dUdtSVANanyG4gGFFpQ3HzCG7xRbpN/7gHLXJoqO9AFbY+XqdTnfAgWH82QYZ1gaMUO5pnL7LrRrFgR7ZypuKIX2Ir0tMM1JExz3eFXHfO2+hvVRvEEWt06h2SDtwrj9FreM0NwJ2OrKBznJ0+pX1xzyrPw536Z+PqXOOBj+l24fAUNzO46rkGP2sBHFKdu4Ot/9lq0ZyAOhv/db0R72UtcXgM+yC4dAyDu4jO4yRMDWuPa0gGo2WcDwV0M0a2elgatadzlWiNCDBmekKDG5+Jj5129KngRmy+YLgXA8X+YY4pAr4lViUpHTxfsGWFiVU1e5jrzarrGd4LtkeLHIwk2MRE63ngKyebbEBg4Xf+Y=;5:H5fPoxpJPDnk6O3mbGrF4YzGFgdJK5s/Y+ijBTHCKPwpiaec85+h+C2uLCBnpOIcEctKj+7XH25F5cOLu6RPTTlecgOFjXA4HxPJLDfvC2sg9rhJdrO67H47tBXykfVSVGLEiAS71MjJgXTU9+DBEfRNEAi1LBdt6pRNC4p4e18=;24:ogD2ZU2OGLy4CpgohG0tRxNOyorh7KwJQjzv7ahHTjq9UiOsna7fdEtlVoL48qe53rgMaZt5wdvVhd6ecnZpQ8dNIkY/w+FcicGRoARVgGY=;7:Ur7oJPTKZcKp+yGAubJweDuQTkM5sVoxf3pVnLUcKq5C80/FCP0zVjnT3oeZ2PkEW0fGluqZAbL5ZIG7dvmIz1FP7Kt6jFjePM0gJaNGjyozCfZ1zVgrSJH4zPlT8RuuskR8W3tsSX8U6VzyaU0EvhcOOJy0zNLW2hp3opXvVjR9rHYPNHbCi4g+B6z4v36egLiGnBV0/wA5/WfCuP+OAhT1ogY8SNcABfhIESdldAOIfKGDLQ4gXXB+BrZBfIJh SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2017 09:49:44.2928 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a7b1c196-5d32-445a-b698-08d536455b14 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3745 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yossef Efraim xfrm_dev_state_add function returns success for unsupported HW SA options. Resulting the calling function to create SW SA without corrlating HW SA. Desipte IPSec device offloading option was chosen. These not supported HW SA options are hard coded within xfrm_dev_state_add function. SW backward compatibility will break if we add any of these option as old HW will fail with new SW. This patch changes the behaviour to return -EINVAL in case unsupported option is chosen. Notifying user application regarding failure and not breaking backward compatibility for newly added HW SA options. Signed-off-by: Yossef Efraim --- net/xfrm/xfrm_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/xfrm/xfrm_device.c b/net/xfrm/xfrm_device.c index 30e5746..dc68d9c 100644 --- a/net/xfrm/xfrm_device.c +++ b/net/xfrm/xfrm_device.c @@ -67,7 +67,7 @@ int xfrm_dev_state_add(struct net *net, struct xfrm_state *x, /* We don't yet support UDP encapsulation, TFC padding and ESN. */ if (x->encap || x->tfcpad || (x->props.flags & XFRM_STATE_ESN)) - return 0; + return -EINVAL; dev = dev_get_by_index(net, xuo->ifindex); if (!dev) { -- 2.8.1