From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752261AbdK3Lqv (ORCPT ); Thu, 30 Nov 2017 06:46:51 -0500 Received: from us-smtp-delivery-194.mimecast.com ([63.128.21.194]:27702 "EHLO us-smtp-delivery-194.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751089AbdK3Lqu (ORCPT ); Thu, 30 Nov 2017 06:46:50 -0500 From: Trond Myklebust To: "torvalds@linux-foundation.org" , "rostedt@goodmis.org" CC: "linux-kernel@vger.kernel.org" , "Anna.Schumaker@netapp.com" , "akpm@linux-foundation.org" Subject: Re: [BUILD FAILURE] nfs4state.c fails to compile with gcc 4.5.4 Thread-Topic: [BUILD FAILURE] nfs4state.c fails to compile with gcc 4.5.4 Thread-Index: AQHTaYfmTNbfgLUaXUSGjTTkZbO55aMsQ1CAgAAEuZeAAAXQAIAAgN4A Date: Thu, 30 Nov 2017 11:46:44 +0000 Message-ID: <1512042402.34281.1.camel@primarydata.com> References: <20171129215853.20172851@vmware.local.home> <20171129193927.e4248d8a797b90aa03edd0ff@linux-foundation.org> <20171129230528.6955b58a@vmware.local.home> In-Reply-To: <20171129230528.6955b58a@vmware.local.home> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [68.49.162.121] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR11MB0073;20:Uo41EBeQjrnHH2Sfz/KuAjk76UmcXJ9Ese6AMhcsIbbSUp0yADPP+tmsmYiiuQKSZZJQxRlszDc41DH3A6rK1as7oTnS7VtycnmqYQPZ68sKwfNFbGAPYPERS39FrpQse9IK3XJChAwp9ob9PobxLKK+6zP6eQtFTHoypG6UlQU= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 073cf20a-0834-47bd-d9f6-08d537e80814 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4603075)(4627115)(201702281549075)(5600026)(4604075)(2017052603285);SRVR:DM5PR11MB0073; x-ms-traffictypediagnostic: DM5PR11MB0073: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3231022)(3002001)(6041248)(20161123558100)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(2016111802025)(20161123560025)(6072148)(6043046)(201708071742011);SRVR:DM5PR11MB0073;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:DM5PR11MB0073; x-forefront-prvs: 05079D8470 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39830400002)(376002)(346002)(366004)(54094003)(199003)(189002)(24454002)(377424004)(81156014)(103116003)(2501003)(77096006)(36756003)(33646002)(106356001)(66066001)(6486002)(8676002)(6116002)(99286004)(50986010)(316002)(54356010)(305945005)(7736002)(76176010)(54906003)(93886005)(25786009)(97736004)(110136005)(4001150100001)(68736007)(81166006)(3846002)(102836003)(478600001)(2906002)(189998001)(3280700002)(3660700001)(8936002)(6506006)(86362001)(14454004)(2950100002)(5660300001)(229853002)(6246003)(2900100001)(105586002)(6512007)(575784001)(101416001)(4326008)(6436002)(53936002)(32563001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR11MB0073;H:DM5PR11MB0075.namprd11.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-ID: <195AAF8C4CDEC546849BFF6513B8A514@namprd11.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: primarydata.com X-MS-Exchange-CrossTenant-Network-Message-Id: 073cf20a-0834-47bd-d9f6-08d537e80814 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2017 11:46:44.8816 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 03193ed6-8726-4bb3-a832-18ab0d28adb7 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB0073 X-MC-Unique: SmEZAjCkP36Le_ms3UOScQ-1 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vAUBkucR014638 On Wed, 2017-11-29 at 23:05 -0500, Steven Rostedt wrote: > On Wed, 29 Nov 2017 19:44:33 -0800 > Linus Torvalds wrote: > > I keep older compilers around to test ftrace before -mfentry was > introduced. > > I wonder if I should just add a config to force the use without > -mfentry even if the compiler supports it. > > > fs/nfs/nfs4state.c | 3 +-- > > include/linux/nfs4.h | 2 +- > > 2 files changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c > > index 54fd56d715a8..9db5d0d57fcb 100644 > > --- a/fs/nfs/nfs4state.c > > +++ b/fs/nfs/nfs4state.c > > @@ -71,8 +71,7 @@ const nfs4_stateid zero_stateid = { > > }; > > const nfs4_stateid invalid_stateid = { > > { > > - .seqid = cpu_to_be32(0xffffffffU), > > - .other = { 0 }, > > + { .seqid = cpu_to_be32(0xffffffffU), .other = { 0 > > }, }, > > I tried this and it failed. > > > }, > > .type = NFS4_INVALID_STATEID_TYPE, > > }; > > diff --git a/include/linux/nfs4.h b/include/linux/nfs4.h > > index 47adac640191..e394ba0cd6c5 100644 > > --- a/include/linux/nfs4.h > > +++ b/include/linux/nfs4.h > > @@ -53,11 +53,11 @@ typedef struct { char data[NFS4_VERIFIER_SIZE]; > > } nfs4_verifier; > > > > struct nfs4_stateid_struct { > > union { > > - char data[NFS4_STATEID_SIZE]; > > struct { > > __be32 seqid; > > char other[NFS4_STATEID_OTHER_SIZE]; > > } __attribute__ ((packed)); > > + char data[NFS4_STATEID_SIZE]; > > But I didn't try this. This looks to be the key. > > This works for me. > > Tested-by: Steven Rostedt (VMware) > > -- Steve > > > }; > > > > enum { > > We already have a fix queued up for this issue. It was reported and the patch hit linux-nfs+linux-kernel almost 2 weeks ago. Anna? -- Trond Myklebust Linux NFS client maintainer, PrimaryData trond.myklebust@primarydata.com