From: kaiwan.billimoria@gmail.com
To: "Tobin C. Harding" <me@tobin.cc>
Cc: Alexander Kapshuk <alexander.kapshuk@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
kernel-hardening@lists.openwall.com
Subject: Re: [PATCH] leaking_addresses: add support for 32-bit kernel addresses
Date: Mon, 04 Dec 2017 10:11:21 +0530 [thread overview]
Message-ID: <1512362481.17323.9.camel@gmail.com> (raw)
In-Reply-To: <20171204001106.GB27780@eros>
On Mon, 2017-12-04 at 11:11 +1100, Tobin C. Harding wrote:
> On Fri, Dec 01, 2017 at 06:39:07PM +0530, kaiwan.billimoria@gmail.com wrote:
> > @@ -267,7 +266,7 @@ sub is_false_positive
> > sub is_false_positive_ix86_32
> > {
> > my ($match) = @_;
> > - state $page_offset = get_page_offset(); # only gets called once
> > + state $page_offset = eval get_page_offset(); # only gets called once
>
> Why do you use 'eval' here?
>
Without the eval:
i.e.
state $page_offset = get_page_offset(); # only gets called once
$ ./leaking_addresses.pl |head -200
Argument "0x80000000" isn't numeric in numeric lt (<) at ./leaking_addresses.pl line 277.
...
With the 'eval', no warning, it's fine.
Additional Comments:
a) When running in debug mode, print the arch we're currently running on
b) Also, while checking, I found another bug; requires the fix below (strip the filename of LF).
Patch follows:
---
diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl
index 3a8691a642c8..9906dcf8b807 100755
--- a/scripts/leaking_addresses.pl
+++ b/scripts/leaking_addresses.pl
@@ -158,8 +158,8 @@ if (!$input_raw and ($squash_by_path or $squash_by_filename)) {
exit(128);
}
+show_detected_architecture() if $debug;
if (!is_supported_architecture()) {
- show_detected_architecture() if $debug;
printf "\nScript does not support your architecture, sorry.\n";
printf "\nCurrently we support: \n\n";
foreach(@SUPPORTED_ARCHITECTURES) {
@@ -313,6 +313,7 @@ sub get_page_offset
}
foreach my $config_file (@config_files) {
+ $config_file =~ s/\R*//g;
$page_offset = parse_kernel_config_file($config_file);
if ($page_offset ne "") {
return $page_offset;
Thanks,
Kaiwan.
> thanks,
> Tobin.
next prev parent reply other threads:[~2017-12-04 4:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 6:32 [PATCH] leaking_addresses: add support for 32-bit kernel addresses Tobin C. Harding
2017-11-28 13:16 ` Alexander Kapshuk
2017-11-28 21:10 ` Tobin C. Harding
2017-11-29 7:59 ` Alexander Kapshuk
2017-11-29 10:16 ` Tobin C. Harding
2017-11-29 11:02 ` Kaiwan N Billimoria
2017-11-29 20:48 ` Tobin C. Harding
2017-12-01 13:03 ` Kaiwan N Billimoria
2017-12-01 13:09 ` kaiwan.billimoria
2017-12-04 0:11 ` Tobin C. Harding
2017-12-04 4:41 ` kaiwan.billimoria [this message]
2017-12-04 4:55 ` Tobin C. Harding
2017-12-04 5:09 ` Kaiwan N Billimoria
2017-12-04 5:21 ` Kaiwan N Billimoria
2017-12-04 8:21 ` Tobin C. Harding
2017-12-04 10:20 ` kaiwan.billimoria
2017-12-04 12:37 ` Alexander Kapshuk
2017-12-04 14:08 ` Kaiwan N Billimoria
2017-12-04 20:59 ` Tobin C. Harding
2017-11-29 11:30 ` Alexander Kapshuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512362481.17323.9.camel@gmail.com \
--to=kaiwan.billimoria@gmail.com \
--cc=alexander.kapshuk@gmail.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).