From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S945504AbcJaSYy (ORCPT ); Mon, 31 Oct 2016 14:24:54 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:35645 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S943966AbcJaSYv (ORCPT ); Mon, 31 Oct 2016 14:24:51 -0400 X-AuditID: cbfee61b-f793d6d000005a2a-f3-58178c709a1f From: Bartlomiej Zolnierkiewicz To: Russell King - ARM Linux Cc: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Dmitry Eremin-Solenikov , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Olof Johansson , Kevin Hilman , "Nori, Sekhar" Subject: Re: [RESEND PATCH] arm: assabet_defconfig: disable IDE subsystem Date: Mon, 31 Oct 2016 19:24:46 +0100 Message-id: <1512445.DtnT51NQqg@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <2291876.8LAt3RcuXX@amdc3058> References: <1467991490-24895-1-git-send-email-b.zolnierkie@samsung.com> <20161031154622.GB1041@n2100.armlinux.org.uk> <2291876.8LAt3RcuXX@amdc3058> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDIsWRmVeSWpSXmKPExsVy+t9jAd2CHvEIg/srlC3+TjrGbjHpyXtm i5/tW5gsNj2+xmpxbMcjJovLu+awWRyaupfRYn/vBiaLU9c/szlwely+dpHZ4/evSYwe72+0 snvsnHWX3WPzknqPKyeaWD2O39jO5PF5k1wAR5SbTUZqYkpqkUJqXnJ+SmZeuq1SaIibroWS Ql5ibqqtUoSub0iQkkJZYk4pkGdkgAYcnAPcg5X07RLcMh48OMVS8EW04vqc20wNjJ8Fuhg5 OCQETCT+7nfoYuQEMsUkLtxbz9bFyMUhJLCUUWLt17UsEM5XRom5m24yglSxCVhJTGxfBWaL ADUfO/gFrIhZYC6TxPPlh9lBpgoLeEps+KUDYrIIqEosOlAFUs4roCmxuvE8O4gtKuAlsWVf OxOIzSmgJXF13iN2iF3TGCWOTehnh2gQlPgx+R4LiM0sIC+xb/9UVghbS2L9zuNMExgFZiEp m4WkbBaSsgWMzKsYJVILkguKk9JzjfJSy/WKE3OLS/PS9ZLzczcxgmPymfQOxsO73A8xCnAw KvHwNmSJRwixJpYVV+YeYpTgYFYS4f3bCRTiTUmsrEotyo8vKs1JLT7EaAr04ERmKdHkfGC6 yCuJNzQxNzE3NrAwt7Q0MVIS522c/SxcSCA9sSQ1OzW1ILUIpo+Jg1OqgXHm5IgnjKe7+504 uO1CLlpcfZG37MDE0tVWDW6phUJ3mn4a/OqfMeevdXXJ4coD00MncDK//Tz7vX6rtv7u1Srv dx7JyRDdzP49olpHcw5nwUJTdg/P22qm126UZe3ae2Nz2K6He19MEj7gn+PZdjvp+aKT/TO6 A+dcfHf79aeeRXsWS+tqBU1TYinOSDTUYi4qTgQARRz6It8CAAA= X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, October 31, 2016 07:14:13 PM Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Monday, October 31, 2016 03:46:22 PM Russell King - ARM Linux wrote: > > On Wed, Oct 26, 2016 at 07:01:12PM +0200, Bartlomiej Zolnierkiewicz wrote: > > > > > > Hi, > > > > > > On Wednesday, July 13, 2016 04:37:31 PM Arnd Bergmann wrote: > > > > On Wednesday, July 13, 2016 12:59:23 PM CEST Bartlomiej Zolnierkiewicz wrote: > > > > > > > > > > On Friday, July 08, 2016 10:23:48 PM Arnd Bergmann wrote: > > > > > > On Friday, July 8, 2016 5:24:41 PM CEST Bartlomiej Zolnierkiewicz wrote: > > > > > > > This patch disables deprecated IDE subsystem in assabet_defconfig > > > > > > > (no IDE host drivers are selected in this config so there is no > > > > > > > valid reason to enable IDE subsystem itself). > > > > > > > > > > > > > > Cc: Dmitry Eremin-Solenikov > > > > > > > Signed-off-by: Bartlomiej Zolnierkiewicz > > > > > > > > > > > > I think the series makes a lot of sense. I have checked your assertions > > > > > > in the changelogs and found no flaws in your logic, so I think we should > > > > > > take them all through arm-soc unless there are other concerns. > > > > > > > > > > Thank you. > > > > > > > > > > Should I resend everything or just patches that were not reposted yet > > > > > (the ones that were marked as RFT initially and got no feedback)? > > > > > > > > I'd be fine with just getting a pull request with all the patches that > > > > had no negative feedback and that were not already applied (if any). > > > > > > Here it is (sorry for taking so long). > > > > I've just been digging in the dmesg logs from when I was using the > > Assabet+Neponset as my firewall, and it was having to use the IDE > > ide-cs driver rather than the pata pcmcia driver. > > > > I don't recall whether the pata pcmcia driver was a problem or not, > > as the PCMCIA interface can't cope with _any_ 32-bit accesses. I > > think PATA tries to use the "highest" possible access size by > > default... > > It doesn't actually - it defaults to 16-bits for PIO data access and > you must explicitly enable 32-bits using ATA_PFLAG_PIO32 port flag > (pata_pcmcia doesn't set it so it should be okay). Also taskfile > registers are accessed using 8-bits access by default transport > functions (which are used by pata_pcmcia). Please also note that: - assebet_defconfig currently doesn't even enable ide-cs (CONFIG_BLK_DEV_IDECS) in the mainline kernel - neponset_defconfig doesn't even enable IDE (CONFIG_IDE) in the mainline kernel so there is no risk of breaking anything.. :-) Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics