From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752620AbdLGV1b (ORCPT ); Thu, 7 Dec 2017 16:27:31 -0500 Received: from smtprelay0088.hostedemail.com ([216.40.44.88]:40826 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752418AbdLGV13 (ORCPT ); Thu, 7 Dec 2017 16:27:29 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:69:355:379:541:599:800:960:967:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1544:1593:1594:1605:1711:1730:1747:1777:1792:2197:2198:2199:2200:2393:2525:2553:2560:2563:2682:2685:2692:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3622:3653:3865:3866:3867:3870:3871:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:7903:8957:9025:9592:10004:10848:11026:11232:11473:11658:11914:12043:12291:12555:12663:12679:12683:12740:12760:12895:13153:13228:13439:14181:14659:14721:21080:21221:21433:21611:21627:30022:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: ants76_6c4b4aa23b45 X-Filterd-Recvd-Size: 4973 Message-ID: <1512682043.1845.10.camel@perches.com> Subject: Re: [PATCH v2 3/3] checkpatch: warn for use of %px From: Joe Perches To: "Tobin C. Harding" Cc: Andy Whitcroft , linux-kernel@vger.kernel.org Date: Thu, 07 Dec 2017 13:27:23 -0800 In-Reply-To: <20171207211539.GL2191@eros> References: <1512531428-3592-1-git-send-email-me@tobin.cc> <1512531428-3592-4-git-send-email-me@tobin.cc> <20171207210653.GK2191@eros> <20171207211539.GL2191@eros> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-12-08 at 08:15 +1100, Tobin C. Harding wrote: > On Fri, Dec 08, 2017 at 08:06:53AM +1100, Tobin C. Harding wrote: > > On Wed, Dec 06, 2017 at 02:37:08PM +1100, Tobin C. Harding wrote: > > > Usage of the new %px specifier potentially leaks sensitive > > > inforamtion. Printing kernel addresses exposes the kernel layout in > > > memory, this is potentially exploitable. We have tools in the kernel to > > > help us do the right thing. We can have checkpatch warn developers of > > > potential dangers of using %px. > > > > > > Have checkpatch emit a warning for usage of specifier %px. > > > > > > Signed-off-by: Tobin C. Harding > > > Co-developed-by: Joe Perches > > > > Co-Developed-by: > > > > Woops. > > > > Joe I didn't quite understand what you meant when you said that this > > could go in via any tree. I'm still learning the whole kernel tree > > management thing. Don't checkpatch patches go in via Andy's tree? > > > > https://git.kernel.org/pub/scm/linux/kernel/git/apw/checkpatch.git/ > > Oh, I see that tree is not super active. If there are no NACK's do you > want me to put this through my tree? Perhaps once the Co-Developed-by > stuff is in an acceptable form we could put them all together? Please do > say if I'm going about things wrong, here to learn. No worries, you could push it through your tree. btw: Here's an attempt at the case-sensitive signature matching --- scripts/checkpatch.pl | 47 ++++++++++++++++++++++++------------------ ----- 1 file changed, 24 insertions(+), 23 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 6b130a4116fa..59e8d62e0eb0 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -461,16 +461,18 @@ our $logFunctions = qr{(?x: seq_vprintf|seq_printf|seq_puts )}; -our $signature_tags = qr{(?xi: - Signed-off-by:| - Acked-by:| - Tested-by:| - Reviewed-by:| - Reported-by:| - Suggested-by:| - To:| - Cc: -)}; +our @valid_signatures = ( + "Signed-off-by:", + "Acked-by:", + "Tested-by:", + "Reviewed-by:", + "Reported-by:", + "Suggested-by:", + "Co-Developed-by:", + "To:", + "Cc:" +); +my $signature_tags = "(?x:" . join('|', @valid_signatures) . ")"; our @typeListMisordered = ( qr{char\s+(?:un)?signed}, @@ -2467,35 +2469,34 @@ sub process { my $sign_off = $2; my $space_after = $3; my $email = $4; - my $ucfirst_sign_off = ucfirst(lc($sign_off)); + my $preferred_sign_off = ucfirst(lc($sign_off)); - if ($sign_off !~ /$signature_tags/) { + if ($sign_off !~ /$signature_tags/i) { WARN("BAD_SIGN_OFF", "Non-standard signature: $sign_off\n" . $herecurr); - } - if (defined $space_before && $space_before ne "") { + } elsif ($sign_off !~ /$signature_tags/) { + $preferred_sign_off = $valid_signatures[ grep { $valid_signatures[$_] eq $sign_off } 0..$#valid_signatures ]; if (WARN("BAD_SIGN_OFF", - "Do not use whitespace before $ucfirst_sign_off\n" . $herecurr) && + "'$preferred_sign_off' is the preferred signature form\n" . $herecurr) && $fix) { - $fixed[$fixlinenr] = - "$ucfirst_sign_off $email"; + $fixed[$fixlinenr] = "$preferred_sign_off $email"; } } - if ($sign_off =~ /-by:$/i && $sign_off ne $ucfirst_sign_off) { + if (defined $space_before && $space_before ne "") { if (WARN("BAD_SIGN_OFF", - "'$ucfirst_sign_off' is the preferred signature form\n" . $herecurr) && + "Do not use whitespace before $preferred_sign_off\n" . $herecurr) && $fix) { $fixed[$fixlinenr] = - "$ucfirst_sign_off $email"; + "$preferred_sign_off $email"; } - } + if (!defined $space_after || $space_after ne " ") { if (WARN("BAD_SIGN_OFF", - "Use a single space after $ucfirst_sign_off\n" . $herecurr) && + "Use a single space after $preferred_sign_off\n" . $herecurr) && $fix) { $fixed[$fixlinenr] = - "$ucfirst_sign_off $email"; + "$preferred_sign_off $email"; } }