From: Sven Van Asbroeck <svendev@arcx.com>
To: <svendev@arcx.com>, <wsa@the-dreams.de>, <brgl@bgdev.pl>,
<nsekhar@ti.com>, <sakari.ailus@linux.intel.com>,
<javier@dowhile0.org>, <divagar.mohandass@intel.com>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-i2c@vger.kernel.org>
Subject: [PATCH v2 2/2] eeprom: at24: remove temporary fix for at24mac402 size.
Date: Fri, 8 Dec 2017 16:25:06 -0500 [thread overview]
Message-ID: <1512768306-14816-3-git-send-email-svendev@arcx.com> (raw)
In-Reply-To: <1512768306-14816-1-git-send-email-svendev@arcx.com>
The chip size passed via devicetree, i2c, or acpi device ids is
now no longer limited to a power of two. So the temporary
fix can be removed.
Signed-off-by: Sven Van Asbroeck <svendev@arcx.com>
---
drivers/misc/eeprom/at24.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index c3759cb..e522350 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -569,16 +569,6 @@ static int at24_probe(struct i2c_client *client, const struct i2c_device_id *id)
dev_warn(&client->dev,
"page_size looks suspicious (no power of 2)!\n");
- /*
- * REVISIT: the size of the EUI-48 byte array is 6 in at24mac402, while
- * the call to ilog2() in AT24_DEVICE_MAGIC() rounds it down to 4.
- *
- * Eventually we'll get rid of the magic values altoghether in favor of
- * real structs, but for now just manually set the right size.
- */
- if (chip.flags & AT24_FLAG_MAC && chip.byte_len == 4)
- chip.byte_len = 6;
-
if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C) &&
!i2c_check_functionality(client->adapter,
I2C_FUNC_SMBUS_WRITE_I2C_BLOCK))
--
1.9.1
next prev parent reply other threads:[~2017-12-08 21:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 21:25 [PATCH v2 0/2] eeprom: at24: convert magic numbers to structs Sven Van Asbroeck
2017-12-08 21:25 ` [PATCH v2 1/2] " Sven Van Asbroeck
2017-12-11 13:55 ` Bartosz Golaszewski
2017-12-12 16:56 ` Sven Dev
2017-12-18 14:29 ` Bartosz Golaszewski
2017-12-08 21:25 ` Sven Van Asbroeck [this message]
2017-12-20 17:18 ` [PATCH v2 2/2] eeprom: at24: remove temporary fix for at24mac402 size Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512768306-14816-3-git-send-email-svendev@arcx.com \
--to=svendev@arcx.com \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=divagar.mohandass@intel.com \
--cc=javier@dowhile0.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=sakari.ailus@linux.intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).