From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753237AbdLHVjs (ORCPT ); Fri, 8 Dec 2017 16:39:48 -0500 Received: from mail-lf0-f65.google.com ([209.85.215.65]:35349 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752557AbdLHVjr (ORCPT ); Fri, 8 Dec 2017 16:39:47 -0500 X-Google-Smtp-Source: AGs4zMYshPmvLkDcHq6uOU7KnflQSE7UxECQUKIi9P5AwJ+/Ggp+IdWgL/xKmvzUcojuGmaVjMe/bQ== From: Vasyl Gomonovych To: rostedt@goodmis.org, mingo@kernel.org, karolherbst@gmail.com, ppaalanen@gmail.com, tglx@linutronix.de, hpa@zytor.com, gomonovych@gmail.com Cc: x86@kernel.org, linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org Subject: [PATCH] x86/mm/kmmio: Fix returned errno code Date: Fri, 8 Dec 2017 22:39:34 +0100 Message-Id: <1512769174-15792-1-git-send-email-gomonovych@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org add_kmmio_fault_page using -1 instead of the -ENOMEM defined macro to specify kmmio_fault_page allocation failed. Smatch tool warning: arch/x86/mm/kmmio.c:389 add_kmmio_fault_page() warn: returning -1 instead of -ENOMEM is sloppy Signed-off-by: Vasyl Gomonovych --- arch/x86/mm/kmmio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/mm/kmmio.c b/arch/x86/mm/kmmio.c index c21c2ed..9b92086b 100644 --- a/arch/x86/mm/kmmio.c +++ b/arch/x86/mm/kmmio.c @@ -386,7 +386,7 @@ static int add_kmmio_fault_page(unsigned long addr) f = kzalloc(sizeof(*f), GFP_ATOMIC); if (!f) - return -1; + return -ENOMEM; f->count = 1; f->addr = addr; -- 1.9.1