From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751339AbdLISId (ORCPT ); Sat, 9 Dec 2017 13:08:33 -0500 Received: from smtprelay0140.hostedemail.com ([216.40.44.140]:42653 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751059AbdLISIc (ORCPT ); Sat, 9 Dec 2017 13:08:32 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:800:960:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3870:3871:3872:3876:4321:5007:8603:8784:10004:10400:10848:11026:11232:11473:11658:11914:12043:12296:12438:12555:12740:12895:13069:13311:13357:13439:13894:14181:14659:14721:21080:21451:21611:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: hose61_8492871c3f72e X-Filterd-Recvd-Size: 2028 Message-ID: <1512842909.26342.10.camel@perches.com> Subject: Re: [PATCH 3/3] staging: pi433: Remove unnecessary #ifdef DEBUG around dev_dbg From: Joe Perches To: Simon =?ISO-8859-1?Q?Sandstr=F6m?= , gregkh@linuxfoundation.org Cc: marcin.s.ciupak@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Sat, 09 Dec 2017 10:08:29 -0800 In-Reply-To: <20171209180257.24240-4-simon@nikanor.nu> References: <20171209180257.24240-1-simon@nikanor.nu> <20171209180257.24240-4-simon@nikanor.nu> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2017-12-09 at 19:02 +0100, Simon Sandström wrote: > dev_dbg() already depends on DEBUG. Not quite. It depends on CONFIG_DYNAMIC_DEBUG or DEBUG In any case, this patch is fine. > Signed-off-by: Simon Sandström > --- > drivers/staging/pi433/rf69.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c > index 04a74423c325..6e38e6a515a4 100644 > --- a/drivers/staging/pi433/rf69.c > +++ b/drivers/staging/pi433/rf69.c > @@ -767,9 +767,7 @@ int rf69_read_fifo (struct spi_device *spi, u8 *buffer, unsigned int size) > int retval; > > if (size > FIFO_SIZE) { > -#ifdef DEBUG > dev_dbg(&spi->dev, "read fifo: passed in buffer bigger then internal buffer\n"); > -#endif > return -EMSGSIZE; > } > > @@ -801,9 +799,7 @@ int rf69_write_fifo(struct spi_device *spi, u8 *buffer, unsigned int size) > u8 local_buffer[FIFO_SIZE + 1]; > > if (size > FIFO_SIZE) { > -#ifdef DEBUG > dev_dbg(&spi->dev, "read fifo: passed in buffer bigger then internal buffer\n"); > -#endif > return -EMSGSIZE; > } >