From: shrikant.maurya@techveda.org
To: rjw@rjwysocki.net, pavel@ucw.cz, len.brown@intel.com,
gregkh@linuxfoundation.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
sunil.m@techveda.org, karthik@techveda.org, raghu@techveda.org,
Shrikant Maurya <shrikant.maurya@techveda.org>
Subject: [PATCH] drivers: base: power: Fix GFP_KERNEL in spinlock context
Date: Tue, 12 Dec 2017 19:15:42 +0530 [thread overview]
Message-ID: <1513086342-3581-1-git-send-email-shrikant.maurya@techveda.org> (raw)
From: Shrikant Maurya <shrikant.maurya@techveda.org>
As reported by Jia-Ju Bai (https://lkml.org/lkml/2017/12/11/872):
API's are using GFP_KERNEL to allocate memory which may sleep.
To ensure atomicity such allocations must be avoided in critical
sections under spinlock.
Fixed by replacing GFP_KERNEL to GFP_ATOMIC.
Reported-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Shrikant Maurya <shrikant.maurya@techveda.org>
Signed-off-by: Suniel Mahesh <sunil.m@techveda.org>
Signed-off-by: Raghu Bharadwaj <raghu@techveda.org>
Signed-off-by: Karthik Tummala <karthik@techveda.org>
---
Note:
- Patch was compile tested and built(ARCH=arm) on linux-next
(latest).
- No build issues reported.
---
drivers/base/power/wakeup.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c
index 38559f0..de56952 100644
--- a/drivers/base/power/wakeup.c
+++ b/drivers/base/power/wakeup.c
@@ -92,11 +92,11 @@ struct wakeup_source *wakeup_source_create(const char *name)
{
struct wakeup_source *ws;
- ws = kmalloc(sizeof(*ws), GFP_KERNEL);
+ ws = kmalloc(sizeof(*ws), GFP_ATOMIC);
if (!ws)
return NULL;
- wakeup_source_prepare(ws, name ? kstrdup_const(name, GFP_KERNEL) : NULL);
+ wakeup_source_prepare(ws, name ? kstrdup_const(name, GFP_ATOMIC) : NULL);
return ws;
}
EXPORT_SYMBOL_GPL(wakeup_source_create);
--
1.9.1
next reply other threads:[~2017-12-12 13:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 13:45 shrikant.maurya [this message]
2017-12-12 14:58 ` [PATCH] drivers: base: power: Fix GFP_KERNEL in spinlock context Geert Uytterhoeven
2017-12-15 8:45 ` Pavel Machek
2017-12-16 8:15 ` shrikant
2017-12-16 8:14 ` shrikant
2017-12-12 16:55 ` Rafael J. Wysocki
2017-12-16 8:21 ` shrikant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513086342-3581-1-git-send-email-shrikant.maurya@techveda.org \
--to=shrikant.maurya@techveda.org \
--cc=gregkh@linuxfoundation.org \
--cc=karthik@techveda.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=raghu@techveda.org \
--cc=rjw@rjwysocki.net \
--cc=sunil.m@techveda.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).