From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Laurent Vivier <lvivier@redhat.com>, kvm-ppc@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
"Paul Mackerras" <paulus@ozlabs.org>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Cédric Le Goater" <clg@kaod.org>
Subject: Re: [PATCH] KVM: PPC: Book3S HV: Fix pending_pri value in kvmppc_xive_get_icp()
Date: Wed, 13 Dec 2017 07:18:10 +1100 [thread overview]
Message-ID: <1513109890.2303.42.camel@kernel.crashing.org> (raw)
In-Reply-To: <20171212172356.2397-1-lvivier@redhat.com>
On Tue, 2017-12-12 at 18:23 +0100, Laurent Vivier wrote:
> When we migrate a VM from a POWER8 host (XICS) to a POWER9 host
> (XICS-on-XIVE), we have an error:
>
> qemu-kvm: Unable to restore KVM interrupt controller state \
> (0xff000000) for CPU 0: Invalid argument
>
> This is because kvmppc_xics_set_icp() checks the new state
> is internaly consistent, and especially:
>
> ...
> 1129 if (xisr == 0) {
> 1130 if (pending_pri != 0xff)
> 1131 return -EINVAL;
> ...
>
> On the other side, kvmppc_xive_get_icp() doesn't set
> neither the pending_pri value, nor the xisr value (set to 0)
> (and kvmppc_xive_set_icp() ignores the pending_pri value)
>
> As xisr is 0, pending_pri must be set to 0xff.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
next prev parent reply other threads:[~2017-12-12 20:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 17:23 [PATCH] KVM: PPC: Book3S HV: Fix pending_pri value in kvmppc_xive_get_icp() Laurent Vivier
2017-12-12 20:18 ` Benjamin Herrenschmidt [this message]
2017-12-22 11:24 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513109890.2303.42.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=clg@kaod.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lvivier@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).