From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753441AbdLMOW6 (ORCPT ); Wed, 13 Dec 2017 09:22:58 -0500 Received: from mail-by2nam03on0077.outbound.protection.outlook.com ([104.47.42.77]:42400 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753041AbdLMOWt (ORCPT ); Wed, 13 Dec 2017 09:22:49 -0500 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; lists.infradead.org; dkim=none (message not signed) header.d=none;lists.infradead.org; dmarc=fail action=none header.from=nxp.com; Message-ID: <1513174959.2879.32.camel@nxp.com> Subject: Re: [PATCH v6 3/6] kernel/reboot.c: export pm_power_off_prepare From: Leonard Crestez To: Oleksij Rempel , Christoph Hellwig , "Rafael J. Wysocki" CC: Mark Rutland , , "Liam Girdwood" , Shawn Guo , "Michael Turquette" , Stephen Boyd , Russell King , , "Rob Herring" , Mark Brown , , Fabio Estevam , "Andrew Morton" , Linus Torvalds , , Date: Wed, 13 Dec 2017 16:22:39 +0200 In-Reply-To: References: <20171206072402.11694-1-o.rempel@pengutronix.de> <20171206072402.11694-4-o.rempel@pengutronix.de> <20171206231130.GA6235@infradead.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131576485595128327;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.168.50;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(7966004)(336005)(376002)(346002)(39860400002)(39380400002)(2980300002)(1109001)(1110001)(339900001)(199004)(189003)(24454002)(377424004)(53936002)(104016004)(68736007)(36756003)(6306002)(5660300001)(498600001)(81166006)(2870700001)(50466002)(23676004)(81156014)(2950100002)(6246003)(53546011)(8676002)(4326008)(305945005)(103116003)(97736004)(356003)(39060400002)(7416002)(106466001)(50226002)(93886005)(105606002)(229853002)(2906002)(54906003)(5820100001)(316002)(966005)(86362001)(76176011)(8936002)(77096006)(110136005)(85426001)(47776003)(8656006)(99106002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR03MB2354;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD029;1:QvDFUEtnv6avF7QrZdEPEfEPZOpbGViMV+1h4aakYt5913scHn4HYRJ6bhtRS9pLLmU5q788WEG2KeXls/XmRjScVNguUeIEJlaPNAkrOSIVhLvKmrd5YFlLLULKBxxb X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 93443df1-fbbe-4d9e-2207-08d54234f728 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4628075)(201703131517081)(5600026)(4604075)(2017052603307);SRVR:BN3PR03MB2354; X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB2354;3:81eUyHNUEwnzryQT+CKAdGoPPAZm0TGkbNa7LfFpbLVXz66T6RmCn3zZB7PyCB7abxXdZKjOKfpJSom5j/1X+OGH6c6zHBQ4De6MqRhjH68KT/kxTo2Sw1y2ch83kjqj0fByGM1O5FWvfH/0kvyoz8mCGlnC2ghaHiC6obe9quP9JW6S7lunJ3OBp6zc/GnXPZac6uuBvllg6IQa14G/Fxr6kqOEj3JqvuNw/xR2alBbStfCGMFA0dyMLRtgOwwqBEA5tam68uYKjwKkF0frIVAwFwH3YlHbVWAenqOG8MP/xM0BZRi3bhMlOx1gqXQ1ocdGdUKT1u1ckU9vgBTBk3fBwandu0ojOUTkgd+FzU8=;25:9bTLzinKUNgr1495YF+2Sa/4xK/d6HiGZFYM25yI4YC246Sp5DRtAVhyetkF08+JHKwUIt38oxr6Tj60EblyqaANU3ETo3a+yVnc/hT6ZRQOQoDsbvaWUmu31L7up4oSgK4LsHCfyX2NWW8BHui6q3fUCEzIJix5knctXfXX0As0TJGTXRw7W1klArCjiNC9BGG885+TQMOgHXtT1q63MAjB9e6zCwzhZH9g9Y+qRNySUBh0EQh1tGK8G+yyH1o67nGU4/uFyH/n6tTo+NMroRhY7kqhRnagz4udYuOlL1lxpJuYrtV7GyUAmUEe1RiLWNMlojTyEkp8+dGIyKLXBQ== X-MS-TrafficTypeDiagnostic: BN3PR03MB2354: X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB2354;31:vl/VmZz8QfHAFz0ZxGXsRY5beWA7586Br/D82dpBibuJ5J0TGjL5dPGN3qTBSYNLO2pNP5mT0sC8Y+Et1hQC8om/zzJ391W7TAIABXQoOIk6leDVtUz5bbvjuwPucY8JI1M852JNgw9tml1EXsuMUS6OinLNcwyUggp2zCpJzpPoqP60bmoWiESOnPmHqcudjIkHtIFO8yZOZ6AtE9TNUxWyHY2W062H2XJBtTCqRFc=;4:4eVK0aGJtRRGZ/Vd355pxs2M4CS/26Swdl/hNjFSXmq+0VQv23vAAOFpJLfRSvRZaaQmY2RB1UMnLfHJUF3QbLuWutaBOaXOVugzb37N4xq7yEdpLLUFVo5cHaVhrFp5AMJ5K96Xdb5iRA3c9SjqkrLQclXhZKQyT/vDluUJdBs0GAdLOuEvjpxEdk1K5kXEa5cIqOfpymwAqpe8iGxGCDQocGgL76dQyvOUIyHagLR6f6NBj+AZB2foCwtU5Z30Cg1BZEZnm5dKzul2BQJIbQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6095135)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231023)(93006095)(93001095)(6055026)(6096035)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259150)(20161123559100)(20161123556025)(20161123563025)(20161123565025)(20161123561025)(201708071742011);SRVR:BN3PR03MB2354;BCL:0;PCL:0;RULEID:(100000803101)(100110400095)(400006);SRVR:BN3PR03MB2354; X-Forefront-PRVS: 052017CAF1 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjNQUjAzTUIyMzU0OzIzOjhBbU94MTVBRlZ3RnIwbmtxdzcrQkR5VzZr?= =?utf-8?B?bCtHSDY2L1BMNXRpa2pUS2lTdTY2TXlLbTVZVHhNUDcrTXh5T0lZM2dERzdS?= =?utf-8?B?OFpYVTNHRmI4cUZOT1p1T3VDUWxzMmVQbE9FSWNGTkZoNUFLcTkxNktNUUlk?= =?utf-8?B?b1VrOFFySjd6Wi9VTE9aUEVwNTRKN3NOVGVPWWU2OWsxOWt2WUFHamltRWlK?= =?utf-8?B?bVZEZk9peUtuN2RlY1lqTnVpNlM5bXpxUjFXcXo4MzBLUElYaGt5azd6dExR?= =?utf-8?B?NU5aYXA0RS82LzFXaWhmaGRubEh1VTlHa1ZSa2NCc1pPYWRzZmN6WGlKdTJk?= =?utf-8?B?Y1hBcE0rbWxlV0tCZEpUSm00RFFwMHBmbDA3UmdGYjdZRUdpcUU1d0g2bkF1?= =?utf-8?B?MHVTaG1Xc2pCNEZrQU9EUG1SU2hkSEpieUhDbHlxbEV5TmNRNGZSRnpvUUFl?= =?utf-8?B?ZXh0ZVNMdDZvb3dwR3FMVXVPR3g3M1lVOFB5elBWck5zM1VpaFZ0NDEwZXgx?= =?utf-8?B?RVN5T3NsNS8rVmN6OGFleHRMMGhkNnRhbHdSY2hVNGpidW9TK0tJTVRzL1No?= =?utf-8?B?cWtjdFNMY1N3cllWclF1b0svYmxaTTBueHllamNXSGdlN3VTZE9yQTg1NnY0?= =?utf-8?B?cEh0SWNRTDV5VStEb0JIL01vZGQvNmYzRWZsdXlvcWZ2Z3dTZ0NJL01ldnJG?= =?utf-8?B?RjRsY3JKeVNUUzZlY2RkQ1VNeDA1d3lSQ3hUOTJlV3dNZmpXT0I4NitVcHRm?= =?utf-8?B?THZ4UE5mR1RkTEhtVVZ6SDUrWFI3S29vTUpRUlVIbExtODY0RllGa2FXUjEw?= =?utf-8?B?emxJVW1XbWp1ejFaSUJqcFFYR3hNb2VNeE9DU1Q2Y3JCN3FUVy9yRHUrNXJE?= =?utf-8?B?UWZwQmFtNlhNZEg4Wk1hcWZxL3Fhc3U5ckdNb21NbkZHelhLQVBOYnVsVW5j?= =?utf-8?B?SGluajhOVk5DNmlLMS81RytyZk05dlJUQXl3dTBIdTJ5Q0NGRjF3cUJiQ1B6?= =?utf-8?B?b1pyd1dSNGlJVTl1Mnl1MFdWUVU4TXdibFByL01JbXhDcGxZNStLR3B6ay9I?= =?utf-8?B?Q3dFMzFuQzRFZC9lZnBETGpsTkloUnUvZkNzZTJIMVI5ckszM1RoYzRBb1cw?= =?utf-8?B?VzNVOThrZWJVeng0OXpreFA0c003TWFTaEExVTUyZUZ3RGkyV1JFaTlvZWZs?= =?utf-8?B?KzR0ZnpVVGdjK0Vrd2JLKzV1aW9ScHlaNENkMG1HRGpXWE90ZHRYMysyUitr?= =?utf-8?B?cmRrLzNvQzBjR0dCQWlhYWF1eThWUkpmRmZDSElNRjlPbGNyN0d5bUlkRWZu?= =?utf-8?B?NXMvRkJzb1JMdHJCbkdqQkxrUlRibTRLZy8xOTFuRDk3NW5pOHZSK0NKek9v?= =?utf-8?B?bzNXM1R2Q1orYUJGUjNPcS9XSHVLTnJBR3dmbjdIaGU3TUhod0ROT3g4YjRN?= =?utf-8?B?WnVDbFBjU3BWUEpwa3A0em1UalVWd2RoM08wZlUvZUp0K0t3bTgzNmUxZUdD?= =?utf-8?B?RnlqZ3NqUGErMi9Sc2hOcnZPaHEyZXkxcUJUL2xnNldVZGsrRzdMTFBrNVVi?= =?utf-8?B?Z1F5WllqVlRFUm1RenhjdjFRVDhEc0JkQitzU2kxRkpZY1VWVU9xTjFYa29K?= =?utf-8?B?SUtxb013azlVa1lzTU4yY1hxWVVNZkprc0ttSkZNUnZtS1dVN0Z3VUVhanhm?= =?utf-8?B?NUt5cnNwdjBmVnA0YkpKTlNOanpOOWlQMGJXZ3p4c1ltT1dBR2UranA5WkhJ?= =?utf-8?Q?9+yahDquZyqF9hpvZJ3tbdxld50pem/tut/Yg=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB2354;6:eUOTBW+y5zbksPJzbuEIsjGZS+tXV9MNmlDhfGg21XghY3SCh3/3rj2frX7mbQ2ZUr9Qer0lnYpijAZ1JU+h12XAKKsU00ThyP990N/53hK28yk6XJc0SJfdq3oW0oiGapapFa34BNGeuss0vGu+4PXLggiezd+QBDuzuZmxiDnAQj+6m7WiqQ0ARZShqeBeKmfErS98IbahAGlp2Pr7g/1EcPB47I+vzKupGQpCkS60Iwn7UkNFVdWhv1pmJNsGvzfscggKCaM4iQv9thnR8grhfmVkVs7KWgMbma5OE1yA4Bhrd17Minr8znf+LnZMrNL5S6zXUSLfSpehdw1fKYXjUdip8wHcS85lD1tyZBs=;5:ZxwsrV1AwqWQfk+oKku0sFygwmSqRyseEwc7taeE5RmSILspRU/Bi+P36BxQj13zJPNWnOWhHmxVsKyRZkz9330yXbk6R7nF8aB2ECC/YO57mBAIe8FCWaigDNZ/oIbox1LJE56W7iIHvXdAZysVI63uOrZd/BvlswmZFgvdD8I=;24:oSDm+pr5/dPkcRZ0NHDzYYd++MrujR1F29UD3xmBPBFzvl3BIBD540ZDiBVBlypkOgLrXBs84bg13tsnOfNBC0+bdSuBk+QgjtztWPyt14s=;7:G4sniQWyd2/ajfq4voEsGl4hjffqL+Q7bGTQJ3w8b2G913QAJf+vfXU7V7iaRI15dZXJIoHPnpUxI+w1VYx7MeZD8EIGHE5uRRoAsweUowo1f87XvBZMuTjzwOP01688F+3EnopgKRl8rZyCQVUnvP1QBFDVZogT7PqRfKElxsbGt1o9sZUvuEH1Zr+ObotXP3D1nlPk+ChDOjpBDo0YcbJEPaSceIy3zLIJ8GoDGeLfiF49ilg5AvLl50RdL36W SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2017 14:22:39.2632 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 93443df1-fbbe-4d9e-2207-08d54234f728 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2354 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-12-07 at 06:36 +0100, Oleksij Rempel wrote: > > On 07.12.2017 00:11, Christoph Hellwig wrote: > > > > > > > >  void (*pm_power_off_prepare)(void); > > > +EXPORT_SYMBOL(pm_power_off_prepare); > > EXPORT_SYMBOL_GPL for something this deeply internal, please. > Ok, > probably all other symbols should be converted in this file in to > EXPORT_SYMBOL_GPL as well? > > grep EXPORT_SYMBOL kernel/reboot.c > EXPORT_SYMBOL(cad_pid); > EXPORT_SYMBOL(pm_power_off_prepare); > EXPORT_SYMBOL_GPL(emergency_restart); > EXPORT_SYMBOL(register_reboot_notifier); > EXPORT_SYMBOL(unregister_reboot_notifier); > EXPORT_SYMBOL(devm_register_reboot_notifier); > EXPORT_SYMBOL(register_restart_handler); > EXPORT_SYMBOL(unregister_restart_handler); > EXPORT_SYMBOL_GPL(kernel_restart); > EXPORT_SYMBOL_GPL(kernel_halt); > EXPORT_SYMBOL_GPL(kernel_power_off); > EXPORT_SYMBOL_GPL(orderly_poweroff); > EXPORT_SYMBOL_GPL(orderly_reboot); This call looks much more deeply internal than those other functions, it's not like reboot_notifier and restart_handler. It seems that the only user of pm_power_off_prepare right now is the ACPI core and your patch uses it in a regulator driver. This looks extremely strange. Maybe this is why imx maintainers are stalling on this patch? It might help if the ACPI/PM maintainers ack/review this part explicitly, and the usage in part 5: https://patchwork.kernel.org/patch/9799615/ -- Regards, Leonard