From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753294AbcIAXme convert rfc822-to-8bit (ORCPT ); Thu, 1 Sep 2016 19:42:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52504 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753200AbcIAXmc (ORCPT ); Thu, 1 Sep 2016 19:42:32 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20160901.163942.2272956240456598007.davem@davemloft.net> References: <20160901.163942.2272956240456598007.davem@davemloft.net> <147257235268.6716.12062621584578937716.stgit@warthog.procyon.org.uk> <147257235952.6716.3613899854387213654.stgit@warthog.procyon.org.uk> <20160901.163832.1923741041602397930.davem@davemloft.net> To: David Miller Cc: dhowells@redhat.com, netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] rxrpc: Don't expose skbs to in-kernel users MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Date: Fri, 02 Sep 2016 00:42:15 +0100 Message-ID: <15134.1472773335@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 01 Sep 2016 23:42:17 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Miller wrote: > Actually, reverted, this adds a new warning to the build: > > net/rxrpc/recvmsg.c: In function ‘rxrpc_kernel_recv_data’: > net/rxrpc/recvmsg.c:531:1: warning: label ‘need_more_data’ defined but not used [-Wunused-label] > need_more_data: > ^ > net/rxrpc/recvmsg.c:475:7: warning: unused variable ‘no_more’ [-Wunused-variable] > bool no_more; > ^ Yes. I sent a second version. David