Re: [linux-sunxi] [PATCH v4 0/2] Initial Allwinner V3s CSI Support

["Ondřej Jirman" <megous@megous.com>]

[-- Attachment #1: Type: text/plain, Size: 9601 bytes --]

Hello,

Yong Deng píše v Pá 22. 12. 2017 v 17:32 +0800:
> This patchset add initial support for Allwinner V3s CSI.
> 
> Allwinner V3s SoC have two CSI module. CSI0 is used for MIPI interface
> and CSI1 is used for parallel interface. This is not documented in
> datasheet but by testing and guess.
> 
> This patchset implement a v4l2 framework driver and add a binding 
> documentation for it. 
> 
> Currently, the driver only support the parallel interface. And has been
> tested with a BT1120 signal which generating from FPGA. The following
> fetures are not support with this patchset:
>   - ISP 
>   - MIPI-CSI2
>   - Master clock for camera sensor
>   - Power regulator for the front end IC
> 
> Thanks for Ondřej Jirman's help.
> 
> Changes in v4:
>   * Deal with the CSI 'INNER QUEUE'.
>     CSI will lookup the next dma buffer for next frame before the
>     the current frame done IRQ triggered. This is not documented
>     but reported by Ondřej Jirman.
>     The BSP code has workaround for this too. It skip to mark the
>     first buffer as frame done for VB2 and pass the second buffer
>     to CSI in the first frame done ISR call. Then in second frame
>     done ISR call, it mark the first buffer as frame done for VB2
>     and pass the third buffer to CSI. And so on. The bad thing is
>     that the first buffer will be written twice and the first frame
>     is dropped even the queued buffer is sufficient.
>     So, I make some improvement here. Pass the next buffer to CSI
>     just follow starting the CSI. In this case, the first frame
>     will be stored in first buffer, second frame in second buffer.
>     This mothed is used to avoid dropping the first frame, it
>     would also drop frame when lacking of queued buffer.
>   * Fix: using a wrong mbus_code when getting the supported formats
>   * Change all fourcc to pixformat
>   * Change some function names
> 
> Changes in v3:
>   * Get rid of struct sun6i_csi_ops
>   * Move sun6i-csi to new directory drivers/media/platform/sunxi
>   * Merge sun6i_csi.c and sun6i_csi_v3s.c into sun6i_csi.c
>   * Use generic fwnode endpoints parser
>   * Only support a single subdev to make things simple
>   * Many complaintion fix
> 
> Changes in v2: 
>   * Change sunxi-csi to sun6i-csi
>   * Rebase to media_tree master branch 
> 
> Following is the 'v4l2-compliance -s -f' output, I have test this
> with both interlaced and progressive signal:
> 
> # ./v4l2-compliance -s -f
> v4l2-compliance SHA   : 6049ea8bd64f9d78ef87ef0c2b3dc9b5de1ca4a1
> 
> Driver Info:
>         Driver name   : sun6i-video
>         Card type     : sun6i-csi
>         Bus info      : platform:csi
>         Driver version: 4.15.0
>         Capabilities  : 0x84200001
>                 Video Capture
>                 Streaming
>                 Extended Pix Format
>                 Device Capabilities
>         Device Caps   : 0x04200001
>                 Video Capture
>                 Streaming
>                 Extended Pix Format
> 
> Compliance test for device /dev/video0 (not using libv4l2):
> 
> Required ioctls:
>         test VIDIOC_QUERYCAP: OK
> 
> Allow for multiple opens:
>         test second video open: OK
>         test VIDIOC_QUERYCAP: OK
>         test VIDIOC_G/S_PRIORITY: OK
>         test for unlimited opens: OK
> 
> Debug ioctls:
>         test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported)
>         test VIDIOC_LOG_STATUS: OK (Not Supported)
> 
> Input ioctls:
>         test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported)
>         test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
>         test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported)
>         test VIDIOC_ENUMAUDIO: OK (Not Supported)
>         test VIDIOC_G/S/ENUMINPUT: OK
>         test VIDIOC_G/S_AUDIO: OK (Not Supported)
>         Inputs: 1 Audio Inputs: 0 Tuners: 0
> 
> Output ioctls:
>         test VIDIOC_G/S_MODULATOR: OK (Not Supported)
>         test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
>         test VIDIOC_ENUMAUDOUT: OK (Not Supported)
>         test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported)
>         test VIDIOC_G/S_AUDOUT: OK (Not Supported)
>         Outputs: 0 Audio Outputs: 0 Modulators: 0
> 
> Input/Output configuration ioctls:
>         test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported)
>         test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported)
>         test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported)
>         test VIDIOC_G/S_EDID: OK (Not Supported)
> 
> Test input 0:
> 
>         Control ioctls:
>                 test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK (Not Supported)
>                 test VIDIOC_QUERYCTRL: OK (Not Supported)
>                 test VIDIOC_G/S_CTRL: OK (Not Supported)
>                 test VIDIOC_G/S/TRY_EXT_CTRLS: OK (Not Supported)
>                 test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported)
>                 test VIDIOC_G/S_JPEGCOMP: OK (Not Supported)
>                 Standard Controls: 0 Private Controls: 0

I'm not sure if your driver passes control queries to the subdev. It
did not originally, and I'm not sure you picked up the change from my
version of the driver. "Not supported" here seems to indicate that it
does not.

I'd be interested what's the recommended practice here. It sure helps
with some apps that expect to be able to modify various input controls
directly on the /dev/video# device. These are then supported out of the
box.

It's a one-line change. See:

https://www.kernel.org/doc/html/latest/media/kapi/v4l2-controls.html#in
heriting-controls

>         Format ioctls:
>                 test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK
>                 test VIDIOC_G/S_PARM: OK (Not Supported)
>                 test VIDIOC_G_FBUF: OK (Not Supported)
>                 test VIDIOC_G_FMT: OK
>                 test VIDIOC_TRY_FMT: OK
>                 test VIDIOC_S_FMT: OK
>                 test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
>                 test Cropping: OK (Not Supported)
>                 test Composing: OK (Not Supported)
>                 test Scaling: OK (Not Supported)
> 
>         Codec ioctls:
>                 test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported)
>                 test VIDIOC_G_ENC_INDEX: OK (Not Supported)
>                 test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)
> 
>         Buffer ioctls:
>                 test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK
>                 test VIDIOC_EXPBUF: OK
> 
> Test input 0:
> 
> Streaming ioctls:
>         test read/write: OK (Not Supported)
>         test MMAP: OK                                     
>         test USERPTR: OK (Not Supported)
>         test DMABUF: Cannot test, specify --expbuf-device
> 
> Stream using all formats:
>         test MMAP for Format HM12, Frame Size 1280x720:
>                 Stride 1920, Field None: OK                                 
>         test MMAP for Format NV12, Frame Size 1280x720:
>                 Stride 1920, Field None: OK                                 
>         test MMAP for Format NV21, Frame Size 1280x720:
>                 Stride 1920, Field None: OK                                 
>         test MMAP for Format YU12, Frame Size 1280x720:
>                 Stride 1920, Field None: OK                                 
>         test MMAP for Format YV12, Frame Size 1280x720:
>                 Stride 1920, Field None: OK                                 
>         test MMAP for Format NV16, Frame Size 1280x720:
>                 Stride 2560, Field None: OK                                 
>         test MMAP for Format NV61, Frame Size 1280x720:
>                 Stride 2560, Field None: OK                                 
>         test MMAP for Format 422P, Frame Size 1280x720:
>                 Stride 2560, Field None: OK                                 
> 
> Total: 54, Succeeded: 54, Failed: 0, Warnings: 0
> 
> Yong Deng (2):
>   dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)
>   media: V3s: Add support for Allwinner CSI.
> 
>  .../devicetree/bindings/media/sun6i-csi.txt        |  51 ++
>  MAINTAINERS                                        |   8 +
>  drivers/media/platform/Kconfig                     |   1 +
>  drivers/media/platform/Makefile                    |   2 +
>  drivers/media/platform/sunxi/sun6i-csi/Kconfig     |   9 +
>  drivers/media/platform/sunxi/sun6i-csi/Makefile    |   3 +
>  drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 878 +++++++++++++++++++++
>  drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h | 147 ++++
>  .../media/platform/sunxi/sun6i-csi/sun6i_csi_reg.h | 203 +++++
>  .../media/platform/sunxi/sun6i-csi/sun6i_video.c   | 752 ++++++++++++++++++
>  .../media/platform/sunxi/sun6i-csi/sun6i_video.h   |  60 ++
>  11 files changed, 2114 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/sun6i-csi.txt
>  create mode 100644 drivers/media/platform/sunxi/sun6i-csi/Kconfig
>  create mode 100644 drivers/media/platform/sunxi/sun6i-csi/Makefile
>  create mode 100644 drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
>  create mode 100644 drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h
>  create mode 100644 drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_reg.h
>  create mode 100644 drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c
>  create mode 100644 drivers/media/platform/sunxi/sun6i-csi/sun6i_video.h
> 
> -- 
> 1.8.3.1
> 

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]