From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Mathieu Malaterre <malat@debian.org>
Subject: Re: [PATCH] net: ethernet: dm9000: Handle -EPROBE_DEFER in dm9000_parse_dt()
Date: Mon, 17 Feb 2020 11:04:35 +0100 [thread overview]
Message-ID: <1513E253-0E58-4088-84E2-E35F3067BB4B@goldelico.com> (raw)
In-Reply-To: <20200216193943.81134-1-paul@crapouillou.net>
Hi Paul,
> Am 16.02.2020 um 20:39 schrieb Paul Cercueil <paul@crapouillou.net>:
>
> The call to of_get_mac_address() can return -EPROBE_DEFER, for instance
> when the MAC address is read from a NVMEM driver that did not probe yet.
a quick test on the CI20 board shows that it seems to work. Especially
in this config, which would be broken otherwise:
CONFIG_JZ4780_EFUSE=m
CONFIG_DM9000=y
The other way round is not expected to be a problem.
It also serializes
CONFIG_JZ4780_EFUSE=m
CONFIG_DM9000=m
properly.
What I am not sure is if it handles
CONFIG_JZ4780_EFUSE=y
CONFIG_DM9000=y
always correct.
Is the EPROBE_DEFER mechanism also working for drivers
fully compiled into the kernel (I may have been mislead
since EPROBE_DEFER patches are almost always done to make
drivers work as modules)?
If not, it depends on luck to have the EFUSE driver probed
successfully before DM9000.
Anyways you can add my Tested-by: H. Nikolaus Schaller <hns@goldelico.com>
BR and thanks,
Nikolaus
>
> Cc: H. Nikolaus Schaller <hns@goldelico.com>
> Cc: Mathieu Malaterre <malat@debian.org>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> drivers/net/ethernet/davicom/dm9000.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/davicom/dm9000.c b/drivers/net/ethernet/davicom/dm9000.c
> index 1ea3372775e6..e94ae9b94dbf 100644
> --- a/drivers/net/ethernet/davicom/dm9000.c
> +++ b/drivers/net/ethernet/davicom/dm9000.c
> @@ -1405,6 +1405,8 @@ static struct dm9000_plat_data *dm9000_parse_dt(struct device *dev)
> mac_addr = of_get_mac_address(np);
> if (!IS_ERR(mac_addr))
> ether_addr_copy(pdata->dev_addr, mac_addr);
> + else if (PTR_ERR(mac_addr) == -EPROBE_DEFER)
> + return ERR_CAST(mac_addr);
>
> return pdata;
> }
> --
> 2.25.0
>
next prev parent reply other threads:[~2020-02-17 10:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-16 19:39 [PATCH] net: ethernet: dm9000: Handle -EPROBE_DEFER in dm9000_parse_dt() Paul Cercueil
2020-02-16 19:58 ` Andrew Lunn
2020-02-17 4:02 ` David Miller
2020-02-17 10:04 ` H. Nikolaus Schaller [this message]
2020-02-17 12:59 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513E253-0E58-4088-84E2-E35F3067BB4B@goldelico.com \
--to=hns@goldelico.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=malat@debian.org \
--cc=netdev@vger.kernel.org \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).