From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S935621AbeAKTmy (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Thu, 11 Jan 2018 14:42:54 -0500
Received: from imap1.codethink.co.uk ([176.9.8.82]:36616 "EHLO
        imap1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S934560AbeAKTmx (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 11 Jan 2018 14:42:53 -0500
Message-ID: <1515699768.12097.18.camel@codethink.co.uk>
Subject: Re: [PATCH 4.4 020/115] userfaultfd: selftest: vm: allow to build
 in vm/ directory
From: Ben Hutchings <ben.hutchings@codethink.co.uk>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org, Andrea Arcangeli <aarcange@redhat.com>,
        Mike Rapoport <rppt@linux.vnet.ibm.com>,
        "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Pavel Emelyanov <xemul@parallels.com>,
        Hillf Danton <hillf.zj@alibaba-inc.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Sasha Levin <alexander.levin@verizon.com>
Date: Thu, 11 Jan 2018 19:42:48 +0000
In-Reply-To: <20171218152853.415490755@linuxfoundation.org>
References: <20171218152851.886086917@linuxfoundation.org>
         <20171218152853.415490755@linuxfoundation.org>
Organization: Codethink Ltd.
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.22.6-1+deb9u1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Mon, 2017-12-18 at 16:48 +0100, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Andrea Arcangeli <aarcange@redhat.com>
> 
> 
> [ Upstream commit 46aa6a302b53f543f8e8b8e1714dc5e449ad36a6 ]
> 
> linux/tools/testing/selftests/vm $ make
> 
>   gcc -Wall -I ../../../../usr/include     compaction_test.c -lrt -o /compaction_test
>   /usr/lib/gcc/x86_64-pc-linux-gnu/4.9.4/../../../../x86_64-pc-linux-gnu/bin/ld: cannot open output file /compaction_test: Permission denied
>   collect2: error: ld returned 1 exit status
>   make: *** [../lib.mk:54: /compaction_test] Error 1
> 
> Since commit a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT")
> selftests/vm build fails if run from the "selftests/vm" directory, but
> it works in the selftests/ directory.  It's quicker to be able to do a
> local vm-only build after a tree wipe and this patch allows for it
> again.

That commit is not included in 4.4 and nothing under
tools/testing/selftests uses the OUTPUT variable that this defines.

Ben.

[...]
> --- a/tools/testing/selftests/vm/Makefile
> +++ b/tools/testing/selftests/vm/Makefile
> @@ -1,5 +1,9 @@
>  # Makefile for vm selftests
>  
> +ifndef OUTPUT
> +  OUTPUT := $(shell pwd)
> +endif
> +
>  CFLAGS = -Wall -I ../../../../usr/include $(EXTRA_CFLAGS)
>  BINARIES = compaction_test
>  BINARIES += hugepage-mmap
> 
> 
> 
-- 
Ben Hutchings
Software Developer, Codethink Ltd.