From: ufo19890607 <ufo19890607@gmail.com>
To: peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
dsahern@gmail.com, namhyung@kernel.org, milian.wolff@kdab.com,
arnaldo.melo@gmail.com, yuzhoujian@didichuxing.com,
adrian.hunter@intel.com, wangnan0@huawei.com
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
acme@redhat.com
Subject: [PATCH 1/1] perf stat: Add support to print counts for fixed times
Date: Wed, 17 Jan 2018 13:37:25 +0100 [thread overview]
Message-ID: <1516192645-27187-2-git-send-email-ufo19890607@gmail.com> (raw)
In-Reply-To: <1516192645-27187-1-git-send-email-ufo19890607@gmail.com>
From: yuzhoujian <yuzhoujian@didichuxing.com>
Introduce a new option to print counts for fixed number of times
and update perf-stat documentation accordingly.
Show below is the output of the new option for perf stat.
$perf stat -I 1000 --times-print 2 -e cycles -a
# time counts unit events
1.002827089 93,884,870 cycles
2.004231506 56,573,446 cycles
We can just print the counts for several times with this newly introduced
option. The usage of it is a little like vmstat.
$ vmstat -n 1 2
procs -----------memory---------- ---swap-- -----io---- -system-- ------cpu-----
r b swpd free buff cache si so bi bo in cs us sy id wa st
0 0 0 78270544 547484 51732076 0 0 0 20 1 1 1 0 99 0 0
0 0 0 78270512 547484 51732080 0 0 0 16 477 1555 0 0 100 0 0
Signed-off-by: yuzhoujian <yuzhoujian@didichuxing.com>
---
tools/perf/Documentation/perf-stat.txt | 5 +++++
tools/perf/builtin-stat.c | 13 +++++++++++++
tools/perf/util/stat.h | 1 +
3 files changed, 19 insertions(+)
diff --git a/tools/perf/Documentation/perf-stat.txt b/tools/perf/Documentation/perf-stat.txt
index 823fce7674bb..8c4526c287c4 100644
--- a/tools/perf/Documentation/perf-stat.txt
+++ b/tools/perf/Documentation/perf-stat.txt
@@ -146,6 +146,11 @@ Print count deltas every N milliseconds (minimum: 10ms)
The overhead percentage could be high in some cases, for instance with small, sub 100ms intervals. Use with caution.
example: 'perf stat -I 1000 -e cycles -a sleep 5'
+--times-print::
+Print count deltas for fixed number of times.
+This option should be used together with "-I" option.
+ example: 'perf stat -I 1000 --times-print 2 -e cycles -a'
+
--metric-only::
Only print computed metrics. Print them in a single line.
Don't show any raw values. Not supported with --per-thread.
diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 98bf9d32f222..47459109110f 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -168,6 +168,7 @@ static struct timespec ref_time;
static struct cpu_map *aggr_map;
static aggr_get_id_t aggr_get_id;
static bool append_file;
+static bool times_print;
static const char *output_name;
static int output_fd;
static int print_free_counters_hint;
@@ -700,6 +701,10 @@ static int __run_perf_stat(int argc, const char **argv)
while (!waitpid(child_pid, &status, WNOHANG)) {
nanosleep(&ts, NULL);
process_interval();
+ if (times_print == true) {
+ if (--stat_config.times == 0)
+ break;
+ }
}
}
waitpid(child_pid, &status, 0);
@@ -718,6 +723,10 @@ static int __run_perf_stat(int argc, const char **argv)
nanosleep(&ts, NULL);
if (interval)
process_interval();
+ if (times_print == true) {
+ if (--stat_config.times == 0)
+ break;
+ }
}
}
@@ -1891,6 +1900,8 @@ static const struct option stat_options[] = {
"command to run after to the measured command"),
OPT_UINTEGER('I', "interval-print", &stat_config.interval,
"print counts at regular interval in ms (>= 10)"),
+ OPT_INTEGER(0, "times-print", &stat_config.times,
+ "print counts for fixed number of times"),
OPT_SET_UINT(0, "per-socket", &stat_config.aggr_mode,
"aggregate counts per processor socket", AGGR_SOCKET),
OPT_SET_UINT(0, "per-core", &stat_config.aggr_mode,
@@ -2870,6 +2881,8 @@ int cmd_stat(int argc, const char **argv)
"The overhead percentage could be high in some cases. "
"Please proceed with caution.\n");
}
+ if (stat_config.times)
+ times_print = true;
if (perf_evlist__alloc_stats(evsel_list, interval))
goto out;
diff --git a/tools/perf/util/stat.h b/tools/perf/util/stat.h
index dbc6f7134f61..b2f8a347d358 100644
--- a/tools/perf/util/stat.h
+++ b/tools/perf/util/stat.h
@@ -90,6 +90,7 @@ struct perf_stat_config {
bool scale;
FILE *output;
unsigned int interval;
+ int times;
struct runtime_stat *stats;
int stats_num;
};
--
2.14.1
next prev parent reply other threads:[~2018-01-17 12:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 12:37 [PATCH 0/1] perf stat: Add support to print counts for fixed times ufo19890607
2018-01-17 12:37 ` ufo19890607 [this message]
2018-01-23 14:24 ` [PATCH 1/1] " Jiri Olsa
[not found] ` <CAHCio2g-V-ojoi0igHSHNjj3ouzyhU+sO5WJSDHdZXGpUsZ7Ew@mail.gmail.com>
2018-01-24 7:39 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516192645-27187-2-git-send-email-ufo19890607@gmail.com \
--to=ufo19890607@gmail.com \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=arnaldo.melo@gmail.com \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=milian.wolff@kdab.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=wangnan0@huawei.com \
--cc=yuzhoujian@didichuxing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).