From: George Cherian <george.cherian@cavium.com>
To: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org
Cc: wsa@the-dreams.de, Dmitry Bazhenov <dmitry.bazhenov@auriga.com>,
George Cherian <george.cherian@cavium.com>
Subject: [PATCH 1/4] i2c: xlp9xx: return ENXIO on slave address NACK
Date: Thu, 18 Jan 2018 05:39:21 +0000 [thread overview]
Message-ID: <1516253964-4615-1-git-send-email-george.cherian@cavium.com> (raw)
From: Dmitry Bazhenov <dmitry.bazhenov@auriga.com>
Fix the driver violation of the common practice to return
ENXIO error on a slave address NACK.
Signed-off-by: Dmitry Bazhenov <dmitry.bazhenov@auriga.com>
Signed-off-by: George Cherian <george.cherian@cavium.com>
---
drivers/i2c/busses/i2c-xlp9xx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-xlp9xx.c b/drivers/i2c/busses/i2c-xlp9xx.c
index b970bf8..6d78cdc 100644
--- a/drivers/i2c/busses/i2c-xlp9xx.c
+++ b/drivers/i2c/busses/i2c-xlp9xx.c
@@ -324,7 +324,8 @@ static int xlp9xx_i2c_xfer_msg(struct xlp9xx_i2c_dev *priv, struct i2c_msg *msg,
dev_dbg(priv->dev, "transfer error %x!\n", priv->msg_err);
if (priv->msg_err & XLP9XX_I2C_INTEN_BUSERR)
xlp9xx_i2c_init(priv);
- return -EIO;
+ return (priv->msg_err & XLP9XX_I2C_INTEN_NACKADDR) ?
+ -ENXIO : -EIO;
}
if (timeleft == 0) {
--
2.1.4
next reply other threads:[~2018-01-18 5:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 5:39 George Cherian [this message]
2018-01-18 5:39 ` [PATCH 2/4] i2c: xlp9xx: Handle transactions with I2C_M_RECV_LEN properly George Cherian
2018-02-26 20:20 ` Wolfram Sang
2018-01-18 5:39 ` [PATCH 3/4] i2c: xlp9xx: report SMBus block read functionality George Cherian
2018-02-26 20:21 ` Wolfram Sang
2018-01-18 5:39 ` [PATCH 4/4] i2c: xlp9xx: Check for Bus state after every transfer George Cherian
2018-02-26 20:22 ` Wolfram Sang
2018-02-27 5:00 ` George Cherian
2018-02-27 5:11 ` George Cherian
2018-02-27 9:05 ` Wolfram Sang
2018-02-27 9:32 ` George Cherian
2018-02-27 9:04 ` Wolfram Sang
2018-02-27 9:32 ` George Cherian
2018-01-30 14:28 ` [PATCH 1/4] i2c: xlp9xx: return ENXIO on slave address NACK George Cherian
2018-02-22 18:02 ` dann frazier
2018-02-26 20:20 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516253964-4615-1-git-send-email-george.cherian@cavium.com \
--to=george.cherian@cavium.com \
--cc=dmitry.bazhenov@auriga.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).