linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vadim Pasternak <vadimp@mellanox.com>
To: dvhart@infradead.org, andy.shevchenko@gmail.com,
	gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org, jiri@resnulli.us,
	Vadim Pasternak <vadimp@mellanox.com>
Subject: [patch v10 5/6] platform/mellanox: mlxreg-hotplug: Add check for negative adapter number value
Date: Tue, 23 Jan 2018 20:34:24 +0000	[thread overview]
Message-ID: <1516739665-132304-5-git-send-email-vadimp@mellanox.com> (raw)
In-Reply-To: <1516739665-132304-1-git-send-email-vadimp@mellanox.com>

Verify before creation of hotplug device if the associated adapter number
is negative. It could be in case hotplug event is not associated with
hotplug device.

Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
---
v10->v9:
 Fixes added by Vadim:
 - add this patch to the series;
---
 drivers/platform/mellanox/mlxreg-hotplug.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/platform/mellanox/mlxreg-hotplug.c b/drivers/platform/mellanox/mlxreg-hotplug.c
index f841379..b0d7587 100644
--- a/drivers/platform/mellanox/mlxreg-hotplug.c
+++ b/drivers/platform/mellanox/mlxreg-hotplug.c
@@ -96,6 +96,14 @@ struct mlxreg_hotplug_priv_data {
 static int mlxreg_hotplug_device_create(struct device *dev,
 					struct mlxreg_core_data *data)
 {
+	/*
+	 * Return if adapter number is negative. Return if adapter number is
+	 * negative. It could be in case hotplug event is not associated with
+	 * hotplug device.
+	 */
+	if (data->hpdev.nr < 0)
+		return 0;
+
 	data->hpdev.adapter = i2c_get_adapter(data->hpdev.nr);
 	if (!data->hpdev.adapter) {
 		dev_err(dev, "Failed to get adapter for bus %d\n",
-- 
2.1.4

  parent reply	other threads:[~2018-01-23 20:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-23 20:34 [patch v10 1/6] platform/mellanox: mlxreg-hotplug: Remove unused wait.h include Vadim Pasternak
2018-01-23 20:34 ` [patch v10 2/6] platform/mellanox: Group create/destroy with attribute functions Vadim Pasternak
2018-01-23 20:34 ` [patch v10 3/6] platform/mellanox: Rename i2c bus to nr Vadim Pasternak
2018-01-23 20:34 ` [patch v10 4/6] platform/mellanox: mlxreg-hotplug: Modify to use a regmap interface Vadim Pasternak
2018-01-23 22:58   ` Darren Hart
2018-01-24 17:05     ` Vadim Pasternak
2018-01-23 20:34 ` Vadim Pasternak [this message]
2018-01-23 20:34 ` [patch v10 6/6] platform/mellanox: mlxreg-hotplug: Enable building for ARM Vadim Pasternak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1516739665-132304-5-git-send-email-vadimp@mellanox.com \
    --to=vadimp@mellanox.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jiri@resnulli.us \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).