From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932422AbeAWXMZ (ORCPT ); Tue, 23 Jan 2018 18:12:25 -0500 Received: from esa5.hgst.iphmx.com ([216.71.153.144]:22265 "EHLO esa5.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932273AbeAWXMX (ORCPT ); Tue, 23 Jan 2018 18:12:23 -0500 X-IronPort-AV: E=Sophos;i="5.46,403,1511798400"; d="scan'208";a="69848237" From: Bart Van Assche To: "joe@perches.com" , "jthumshirn@suse.de" , "axboe@fb.com" CC: "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" Subject: Re: [PATCH v2] bsg: use pr_debug instead of hand craftet macros Thread-Topic: [PATCH v2] bsg: use pr_debug instead of hand craftet macros Thread-Index: AQHTlDi94BQTIZA2x0+r4KfZE7bmBaOBZ8IAgACvBYA= Date: Tue, 23 Jan 2018 23:12:20 +0000 Message-ID: <1516749137.3339.62.camel@wdc.com> References: <20180123105538.24860-1-jthumshirn@suse.de> <1516711552.8378.30.camel@perches.com> In-Reply-To: <1516711552.8378.30.camel@perches.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [199.255.44.172] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1257;7:myqf+A4r3o1FWSNRYvss7nGQbWKd6ddxjF+TvkRBINgFL1a67WITRNZIIAdGFqpU6mQnenkPMhYv2gj9EN1bEsJuLZpt68lVY5881s9izRv14xl0FBWV9emkrmc9Df42GnvTcLxZ+3eQzJ48PsGGHRyHDPSve4ed4jhq0LR27v8sjlB2aYIwWDyMswWOH7AfoojtuoRZyVCPGkVS/ZItRy9szhkiQ5fNsFrKqfCrfoRl68fQnp41TUCundwr2c8g;20:LxORq6AkAxH6iCaFykGge6QWBTEe22It+1T8+hhCvNbMk7tQ2DeUMlJsKCDmoaQ39KHB7GETH7LHidE/8eEIxhCtRpzD62hf3ojyV75BwXegIxghOgCf/I8ATHqXOzPdwbfF1zg+dq2lL8U59ha/VTOp1mDJ9Ac/L967QZxvRsQ= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: b8d637ef-4ea0-4176-e156-08d562b6c0f0 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020);SRVR:CY1PR0401MB1257; x-ms-traffictypediagnostic: CY1PR0401MB1257: wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(5005006)(8121501046)(3231023)(2400081)(944501161)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041288)(20161123560045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011);SRVR:CY1PR0401MB1257;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0401MB1257; x-forefront-prvs: 05610E64EE x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(376002)(346002)(39860400002)(39380400002)(366004)(377424004)(199004)(189003)(105586002)(81166006)(81156014)(77096007)(25786009)(305945005)(106356001)(2950100002)(97736004)(5660300001)(8676002)(99286004)(26005)(8936002)(6116002)(68736007)(7736002)(4326008)(103116003)(3846002)(6246003)(2900100001)(76176011)(316002)(2906002)(36756003)(478600001)(14454004)(966005)(102836004)(2201001)(3660700001)(86362001)(6512007)(6506007)(53936002)(2501003)(229853002)(6436002)(110136005)(54906003)(66066001)(3280700002)(72206003)(6486002)(6306002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1257;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-microsoft-antispam-message-info: AbcmyFJKL/TDLSDnv4PiWryQLgvri2Uv39QUJ27BctwHq8/KPQTbyGxx87rYXasGJ+UaiKy5ou5ZMLmHWjLrlA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <8B97FB51A332574D8220609ADD185E29@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8d637ef-4ea0-4176-e156-08d562b6c0f0 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2018 23:12:20.1656 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1257 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id w0NNCZqA012146 On Tue, 2018-01-23 at 04:45 -0800, Joe Perches wrote: > Perhaps the email subject could be improved to describe > the new macro and as well, this macro, without a pr_fmt > define somewhat above it loses the __func__ output too. Hmm ... I thought that the pr_debug() output can be configured to include the function name (__func__)? From https://www.kernel.org/doc/html/latest/admin-guide/dynamic-debug-howto.html: The flags are: p enables the pr_debug() callsite. f Include the function name in the printed message l Include line number in the printed message m Include module name in the printed message t Include thread ID in messages not generated from interrupt context _ No flags are set. (Or'd with others on input) Bart.