From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: ARC-Seal: i=1; a=rsa-sha256; t=1516761237; cv=none; d=google.com; s=arc-20160816; b=CG1Nf+A6rNmEHgw5B7rGSlMO3piIlblNv9b3fpLYqniSjGWYJlA0/eaviFShpt4DRI BGPPctGuQDHCRm9z78et6Yuf75VGc6T0UfwZ3vr8WPCsMx2S80PHr6FPHtZyS8hpyEeE V+K+v7v+yoVZoy/gCl8PYr4HEJChTX3EufUy+xehOtzhkfR4pv59hFTgadzY2LQwAk+W QK0kDMCbLfyi6arNCha3Z+sCkIJUm3WUOqNoHG1Mx9AOk2fG2pGbmz3cklC+6sR2wDzx UuElZ6pOo5VOawixCz49z2LGIKLIq8ICAFcUOt+6DBfvrIQxC50+I2Lj08cCJI5wcCFl Q/IA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=M4T17j+2PvauFgnQOSxineGJ7bG2om4h4mSaZ7mgaZ4=; b=gIxjTDu+1ee7wXpYUOEx0LE+5sKSJnr+ZESr6EPqyR/ZwK6Yt/UdPZWEICTNY/p3Jy 2vMGfiGkAiPy8Yisf3L+H0/V5vZ5xj70mJ/hT+Pl2RgN05XsbJe0L097TUklP1JKDzyB FfypCdLc6CyOhaOEjalFhizzEvytcQLNr2CjyMrWKAiv4+DSP3su2IRp2jqp+3cbB+BY Wu0eXzISpWVRh0svL7GTnuQTQ001ETv6KsFRqpSJBZthqXB+CpPBe8ebZLrO0IOV8mEZ M0jblBJsWIzj20Vzwi/NfEOd/+Zsxqf7hsakA36oO5qVZSC0LS3YKeb5be4ViMPcT6mV PM+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=o0GZUIwk; spf=pass (google.com: domain of baijiaju1990@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=baijiaju1990@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=o0GZUIwk; spf=pass (google.com: domain of baijiaju1990@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=baijiaju1990@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com X-Google-Smtp-Source: AH8x225cwsKRVBF2VxKHEG5xpjO1qyWIDSMK8OZ5OJlA73fu1APhmKKAEgEBgn5CCpiIjnYNpWaZHg== From: Jia-Ju Bai To: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, paulo.r.zanoni@intel.com, kstewart@linuxfoundation.org, gregkh@linuxfoundation.org, lukas@wunner.de Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH] kernel: x86: early-quirks: Replace mdelay with usleep_range in apple_airport_reset Date: Wed, 24 Jan 2018 10:38:22 +0800 Message-Id: <1516761502-18360-1-git-send-email-baijiaju1990@gmail.com> X-Mailer: git-send-email 1.7.9.5 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590439431576706769?= X-GMAIL-MSGID: =?utf-8?q?1590439431576706769?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: The function apple_airport_reset is not called in atomic context. Thus mdelay can be replaced with usleep_range, to avoid busy wait. This is reported by a static analysis tool named DCNS written by myself. Signed-off-by: Jia-Ju Bai --- arch/x86/kernel/early-quirks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c index 1e82f78..559e81a 100644 --- a/arch/x86/kernel/early-quirks.c +++ b/arch/x86/kernel/early-quirks.c @@ -604,7 +604,7 @@ static void __init apple_airport_reset(int bus, int slot, int func) if ((pmcsr & PCI_PM_CTRL_STATE_MASK) != PCI_D0) { pmcsr &= ~PCI_PM_CTRL_STATE_MASK; write_pci_config_16(bus, slot, func, BCM4331_PM_CAP + PCI_PM_CTRL, pmcsr); - mdelay(10); + usleep_range(10000, 11000); pmcsr = read_pci_config_16(bus, slot, func, BCM4331_PM_CAP + PCI_PM_CTRL); if ((pmcsr & PCI_PM_CTRL_STATE_MASK) != PCI_D0) { -- 1.7.9.5