From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752533AbeAXCx1 (ORCPT ); Tue, 23 Jan 2018 21:53:27 -0500 Received: from smtprelay0172.hostedemail.com ([216.40.44.172]:32945 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752055AbeAXCxZ (ORCPT ); Tue, 23 Jan 2018 21:53:25 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:967:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2110:2393:2525:2560:2563:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3871:3872:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:6119:9025:10004:10400:10848:11232:11658:11914:12043:12296:12740:12760:12895:13069:13095:13311:13357:13439:14181:14659:14721:14764:14777:21080:21433:21627:30022:30029:30054:30064:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: sail56_3abfb7b45af0b X-Filterd-Recvd-Size: 1604 Message-ID: <1516762398.8378.34.camel@perches.com> Subject: Re: [PATCH v2] bsg: use pr_debug instead of hand craftet macros From: Joe Perches To: Bart Van Assche , "jthumshirn@suse.de" , "axboe@fb.com" Cc: "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" Date: Tue, 23 Jan 2018 18:53:18 -0800 In-Reply-To: <1516749137.3339.62.camel@wdc.com> References: <20180123105538.24860-1-jthumshirn@suse.de> <1516711552.8378.30.camel@perches.com> <1516749137.3339.62.camel@wdc.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2018-01-23 at 23:12 +0000, Bart Van Assche wrote: > On Tue, 2018-01-23 at 04:45 -0800, Joe Perches wrote: > > Perhaps the email subject could be improved to describe > > the new macro and as well, this macro, without a pr_fmt > > define somewhat above it loses the __func__ output too. > > Hmm ... I thought that the pr_debug() output can be configured to include > the function name (__func__)? From Exactly right. > https://www.kernel.org/doc/html/latest/admin-guide/dynamic-debug-howto.html: which is what I wrote when I said use +f. It's just nice to mention these changes in the commit message. cheers, Joe