From: Joe Perches <joe@perches.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Bart Van Assche <Bart.VanAssche@wdc.com>,
"axboe@fb.com" <axboe@fb.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH v2] bsg: use pr_debug instead of hand craftet macros
Date: Wed, 24 Jan 2018 03:13:46 -0800 [thread overview]
Message-ID: <1516792426.8378.40.camel@perches.com> (raw)
In-Reply-To: <20180124080347.hgv6vow4x2wajvku@linux-x5ow.site>
On Wed, 2018-01-24 at 09:03 +0100, Johannes Thumshirn wrote:
> On Tue, Jan 23, 2018 at 06:53:18PM -0800, Joe Perches wrote:
> > On Tue, 2018-01-23 at 23:12 +0000, Bart Van Assche wrote:
> > > On Tue, 2018-01-23 at 04:45 -0800, Joe Perches wrote:
> > > > Perhaps the email subject could be improved to describe
> > > > the new macro and as well, this macro, without a pr_fmt
> > > > define somewhat above it loses the __func__ output too.
> > >
> > > Hmm ... I thought that the pr_debug() output can be configured to include
> > > the function name (__func__)? From
> >
> > Exactly right.
> >
> > > https://www.kernel.org/doc/html/latest/admin-guide/dynamic-debug-howto.html:
> >
> > which is what I wrote when I said use +f.
> >
> > It's just nice to mention these changes in the
> > commit message.
>
> Sorry Joe but this slowly approaches the bikeshedding area. Why should I
> duplicate the dynamic debug howto?
Up to you if you want your commit messages to be
more descriptive of the changes you are making.
next prev parent reply other threads:[~2018-01-24 11:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 10:55 [PATCH v2] bsg: use pr_debug instead of hand craftet macros Johannes Thumshirn
2018-01-23 12:45 ` Joe Perches
2018-01-23 23:12 ` Bart Van Assche
2018-01-24 2:53 ` Joe Perches
2018-01-24 8:03 ` Johannes Thumshirn
2018-01-24 11:13 ` Joe Perches [this message]
2018-01-24 16:24 ` Bart Van Assche
2018-01-24 16:52 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516792426.8378.40.camel@perches.com \
--to=joe@perches.com \
--cc=Bart.VanAssche@wdc.com \
--cc=axboe@fb.com \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).