From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752590AbeA0KWa (ORCPT ); Sat, 27 Jan 2018 05:22:30 -0500 Received: from home.regit.org ([37.187.126.138]:40062 "EHLO home.regit.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751957AbeA0KW2 (ORCPT ); Sat, 27 Jan 2018 05:22:28 -0500 Message-ID: <1517048544.24241.16.camel@regit.org> Subject: Re: [PATCH bpf-next v7 2/5] libbpf: add function to setup XDP From: Eric Leblond To: Daniel Borkmann Cc: alexei.starovoitov@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sat, 27 Jan 2018 11:22:24 +0100 In-Reply-To: References: <4dc597a1-5046-3805-eb81-03a23bf0acbb@iogearbox.net> <20180125000548.12320-1-eric@regit.org> <20180125000548.12320-3-eric@regit.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Score: -1.0 (-) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Sat, 2018-01-27 at 02:23 +0100, Daniel Borkmann wrote: > On 01/25/2018 01:05 AM, Eric Leblond wrote: > > Most of the code is taken from set_link_xdp_fd() in bpf_load.c and > > slightly modified to be library compliant. > > > > Signed-off-by: Eric Leblond > > Acked-by: Alexei Starovoitov > > --- > > tools/lib/bpf/bpf.c | 127 > > +++++++++++++++++++++++++++++++++++++++++++++++++ > > tools/lib/bpf/libbpf.c | 2 + > > tools/lib/bpf/libbpf.h | 4 ++ > > 3 files changed, 133 insertions(+) > > > > diff --git a/tools/lib/bpf/bpf.c b/tools/lib/bpf/bpf.c > > index 5128677e4117..749a447ec9ed 100644 > > --- a/tools/lib/bpf/bpf.c > > +++ b/tools/lib/bpf/bpf.c > > @@ -25,6 +25,17 @@ > > #include > > #include > > #include "bpf.h" > > +#include "libbpf.h" > > +#include "nlattr.h" > > +#include > > Doesn't libbpf pull in already -I$(srctree)/tools/include/uapi? Seems > the > other headers don't need 'uapi/' path prefix. Right, it works without the uapi. > > > +#include > > +#include > > + > > +#ifndef IFLA_XDP_MAX > > +#define IFLA_XDP 43 > > +#define IFLA_XDP_FD 1 > > +#define IFLA_XDP_FLAGS 3 > > +#endif > > Hm, given we pull in tools/include/uapi/linux/netlink.h, shouldn't we > also > get include/uapi/linux/if_link.h dependency in here, so above ifdef > workaround > can be avoided? This values are fixed so we risk nothing by keeping a definition if ever it is not available in system headers. But it is fine with me if you want me to add if_link.h to include/uapi/. BR, -- Eric Leblond Blog: https://home.regit.org/