From: "Sugaya, Taichi" <sugaya.taichi@socionext.com>
To: Stephen Boyd <sboyd@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org
Cc: Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Russell King <linux@armlinux.org.uk>,
Jiri Slaby <jslaby@suse.com>,
Masami Hiramatsu <masami.hiramatsu@linaro.org>,
Jassi Brar <jaswinder.singh@linaro.org>
Subject: Re: [PATCH 06/14] dt-bindings: clock: milbeaut: add Milbeaut clock description
Date: Mon, 3 Dec 2018 17:08:15 +0900 [thread overview]
Message-ID: <15178a7c-7d12-7c10-6093-192754827b5a@socionext.com> (raw)
In-Reply-To: <154356596981.88331.14415961625410424962@swboyd.mtv.corp.google.com>
Hi,
Thank you for your comments.
On 2018/11/30 17:19, Stephen Boyd wrote:
> Quoting Sugaya Taichi (2018-11-18 17:01:11)
>> Add DT bindings document for Milbeaut clock.
>>
>> Signed-off-by: Sugaya Taichi <sugaya.taichi@socionext.com>
>> ---
>> .../devicetree/bindings/clock/milbeaut-clock.txt | 93 ++++++++++++++++++++++
>> 1 file changed, 93 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/clock/milbeaut-clock.txt
>>
>> diff --git a/Documentation/devicetree/bindings/clock/milbeaut-clock.txt b/Documentation/devicetree/bindings/clock/milbeaut-clock.txt
>> new file mode 100644
>> index 0000000..5c093c8
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/milbeaut-clock.txt
>> @@ -0,0 +1,93 @@
>> +Milbeaut M10V Clock Controller Binding
>> +----------------------------------------
>> +Milbeaut clock controller is consists of few oscillators, PLL, multiplexer
>> +and few divider modules
>> +
>> +This binding uses common clock bindings
>> +[1] Documentation/devicetree/bindings/clock/clock-bindings.txt
>> +
>> +Required properties:
>> +- compatible: shall be "socionext,milbeaut-m10v-clk-regs"
>> +- reg: shall contain base address and length of clock registers
>> +- #clock-cells: shall be 0
>> +
>> +Example:
>> + m10v-clk-tree@ {
>> + compatible = "socionext,milbeaut-m10v-clk-regs";
>> + reg = <0x1d021000 0x4000>;
>> +
>> + clocks {
>> + #address-cells = <0>;
>> + #size-cells = <0>;
>> +
>> + uclk40xi: uclk40xi {
>> + compatible = "fixed-clock";
>> + #clock-cells = <0>;
>> + clock-frequency = <40000000>;
>> + };
>> + };
>
> This style of binding is highly discouraged. We don't describe each and
> every clk in DT, we describe clk controllers and their outputs and
> inputs in DT. The driver is the place where the clock controller
> describes the internal clk topology of that controller. Also, fixed
> frequency clks are typically oscillators and those would come from the
> board dts file, but otherwise I wouldn't expect to see fixed frequency
> clks in DT.
I understand. Received the similar comment from Rob in the DT part also.
>
>> + }
>> +
>> +The clock consumer shall specify the desired clock-output of the clock
>> +controller (as defined in [2]) by specifying output-id in its "clock"
>> +phandle cell
>> +[2] arch/arm/boot/dts/milbeaut-m10v-clk.h
>> +
> [...]
>> +
>> +Example
>> + piclk_mux_0: spiclk_mux_0 {
>> + compatible = "socionext,m10v-clk-div";
>> + #clock-cells = <0>;
>> + clocks = <&pll10_div_1_2>;
>> + offset = <bSPICLK>;
>> + mask = <0x3>;
>> + ratios = <4 0x5 2 0x4>;
>> + };
>> +
>> + pll10: pll10 {
>> + compatible = "socionext,m10v-pll-fixed-factor";
>> + #clock-cells = <0>;
>> + clocks = <&uclk40xi>;
>> + offset = <10>;
>> + clock-div = <5>;
>> + clock-mult = <108>;
>> + };
>> +
>> + emmcclk: emmcclk {
>> + compatible = "socionext,m10v-clk-div";
>> + #clock-cells = <0>;
>> + clocks = <&pll11>;
>> + offset = <bEMMCCLK>;
>> + mask = <0x3>;
>> + ratios = <15 0x7 10 0x6 9 0x5 8 0x4>;
>
> Yeah, please no. This whole binding needs a rewrite to not have one node
> per clk.
OK, I will renew the binding.
Thanks.
Sugaya Taichi
>
next prev parent reply other threads:[~2018-12-03 8:08 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 1:01 [PATCH 00/14] Add basic support for Socionext Milbeaut M10V SoCs Sugaya Taichi
2018-11-19 1:01 ` [PATCH 01/14] ARM: milbeaut: Add basic support for Milbeaut m10v SoC Sugaya Taichi
2018-11-19 16:24 ` Rob Herring
2018-11-21 9:33 ` sugaya.taichi
2018-11-19 1:01 ` [PATCH 02/14] dt-bindings: soc: milbeaut: Add Milbeaut trampoline description Sugaya Taichi
2018-11-28 2:01 ` Stephen Boyd
2018-11-29 12:24 ` Sugaya, Taichi
2018-11-30 8:16 ` Stephen Boyd
2018-12-03 7:42 ` Sugaya, Taichi
2018-12-03 15:49 ` Rob Herring
2018-12-04 11:30 ` Sugaya, Taichi
2018-12-04 13:32 ` Rob Herring
2018-12-05 10:30 ` Sugaya, Taichi
2019-01-22 11:36 ` Sugaya, Taichi
2019-01-22 11:50 ` Russell King - ARM Linux admin
2019-01-29 8:28 ` Sugaya, Taichi
2019-01-30 8:40 ` Russell King - ARM Linux admin
2018-11-19 1:01 ` [PATCH 03/14] ARM: milbeaut: Add Milbeaut M10V early printk Sugaya Taichi
2018-11-19 15:21 ` Rob Herring
2018-11-21 4:07 ` sugaya.taichi
2018-11-19 1:01 ` [PATCH 04/14] dt-bindings: timer: Add Milbeaut M10V timer description Sugaya Taichi
2018-12-04 23:03 ` Rob Herring
2018-12-06 7:42 ` Sugaya, Taichi
2018-11-19 1:01 ` [PATCH 05/14] clocksource/drivers/timer-milbeaut: Add Milbeaut M10V timer Sugaya Taichi
2018-11-21 10:08 ` Daniel Lezcano
2018-11-22 2:23 ` Sugaya, Taichi
2018-11-19 1:01 ` [PATCH 06/14] dt-bindings: clock: milbeaut: add Milbeaut clock description Sugaya Taichi
2018-11-30 8:19 ` Stephen Boyd
2018-12-03 8:08 ` Sugaya, Taichi [this message]
2018-11-19 1:01 ` [PATCH 07/14] clock: milbeaut: Add Milbeaut M10V clock control Sugaya Taichi
2018-11-30 8:31 ` Stephen Boyd
2018-12-04 8:26 ` Sugaya, Taichi
2018-12-04 18:15 ` Stephen Boyd
2018-12-05 11:42 ` Sugaya, Taichi
2018-12-04 11:03 ` Masahiro Yamada
2018-12-04 18:14 ` Stephen Boyd
2018-12-05 4:26 ` Masahiro Yamada
2018-12-05 6:57 ` Stephen Boyd
2018-12-26 1:35 ` Sugaya, Taichi
2018-12-28 0:39 ` Stephen Boyd
2018-12-28 6:38 ` Sugaya, Taichi
2018-11-19 1:01 ` [PATCH 08/14] dt-bindings: serial: Add Milbeaut M10V serial description Sugaya Taichi
2018-11-19 1:01 ` [PATCH 09/14] serial: Add Milbeaut M10V serial control Sugaya Taichi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15178a7c-7d12-7c10-6093-192754827b5a@socionext.com \
--to=sugaya.taichi@socionext.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jaswinder.singh@linaro.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=masami.hiramatsu@linaro.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).