From: Laurent Dufour <ldufour@linux.vnet.ibm.com>
To: paulmck@linux.vnet.ibm.com, peterz@infradead.org,
akpm@linux-foundation.org, kirill@shutemov.name,
ak@linux.intel.com, mhocko@kernel.org, dave@stgolabs.net,
jack@suse.cz, Matthew Wilcox <willy@infradead.org>,
benh@kernel.crashing.org, mpe@ellerman.id.au, paulus@samba.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
hpa@zytor.com, Will Deacon <will.deacon@arm.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
kemi.wang@intel.com, sergey.senozhatsky.work@gmail.com,
Daniel Jordan <daniel.m.jordan@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
haren@linux.vnet.ibm.com, khandual@linux.vnet.ibm.com,
npiggin@gmail.com, bsingharora@gmail.com,
Tim Chen <tim.c.chen@linux.intel.com>,
linuxppc-dev@lists.ozlabs.org, x86@kernel.org
Subject: [PATCH v8 12/24] mm/migrate: Pass vm_fault pointer to migrate_misplaced_page()
Date: Fri, 16 Feb 2018 16:25:26 +0100 [thread overview]
Message-ID: <1518794738-4186-13-git-send-email-ldufour@linux.vnet.ibm.com> (raw)
In-Reply-To: <1518794738-4186-1-git-send-email-ldufour@linux.vnet.ibm.com>
migrate_misplaced_page() is only called during the page fault handling so
it's better to pass the pointer to the struct vm_fault instead of the vma.
This way during the speculative page fault path the saved vma->vm_flags
could be used.
Signed-off-by: Laurent Dufour <ldufour@linux.vnet.ibm.com>
---
include/linux/migrate.h | 4 ++--
mm/memory.c | 2 +-
mm/migrate.c | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/linux/migrate.h b/include/linux/migrate.h
index 0c6fe904bc97..08960ec74246 100644
--- a/include/linux/migrate.h
+++ b/include/linux/migrate.h
@@ -126,14 +126,14 @@ static inline void __ClearPageMovable(struct page *page)
#ifdef CONFIG_NUMA_BALANCING
extern bool pmd_trans_migrating(pmd_t pmd);
extern int migrate_misplaced_page(struct page *page,
- struct vm_area_struct *vma, int node);
+ struct vm_fault *vmf, int node);
#else
static inline bool pmd_trans_migrating(pmd_t pmd)
{
return false;
}
static inline int migrate_misplaced_page(struct page *page,
- struct vm_area_struct *vma, int node)
+ struct vm_fault *vmf, int node)
{
return -EAGAIN; /* can't migrate now */
}
diff --git a/mm/memory.c b/mm/memory.c
index 66a79f44f303..bd5de1aa3f7a 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -3903,7 +3903,7 @@ static int do_numa_page(struct vm_fault *vmf)
}
/* Migrate to the requested node */
- migrated = migrate_misplaced_page(page, vma, target_nid);
+ migrated = migrate_misplaced_page(page, vmf, target_nid);
if (migrated) {
page_nid = target_nid;
flags |= TNF_MIGRATED;
diff --git a/mm/migrate.c b/mm/migrate.c
index 5d0dc7b85f90..ad8692ca6a4f 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -1900,7 +1900,7 @@ bool pmd_trans_migrating(pmd_t pmd)
* node. Caller is expected to have an elevated reference count on
* the page that will be dropped by this function before returning.
*/
-int migrate_misplaced_page(struct page *page, struct vm_area_struct *vma,
+int migrate_misplaced_page(struct page *page, struct vm_fault *vmf,
int node)
{
pg_data_t *pgdat = NODE_DATA(node);
@@ -1913,7 +1913,7 @@ int migrate_misplaced_page(struct page *page, struct vm_area_struct *vma,
* with execute permissions as they are probably shared libraries.
*/
if (page_mapcount(page) != 1 && page_is_file_cache(page) &&
- (vma->vm_flags & VM_EXEC))
+ (vmf->vma_flags & VM_EXEC))
goto out;
/*
--
2.7.4
next prev parent reply other threads:[~2018-02-16 15:26 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 15:25 [PATCH v8 00/24] Speculative page faults Laurent Dufour
2018-02-16 15:25 ` [PATCH v8 01/24] mm: Introduce CONFIG_SPECULATIVE_PAGE_FAULT Laurent Dufour
2018-02-16 15:25 ` [PATCH v8 02/24] x86/mm: Define CONFIG_SPECULATIVE_PAGE_FAULT Laurent Dufour
2018-02-16 15:25 ` [PATCH v8 03/24] powerpc/mm: " Laurent Dufour
2018-02-16 15:25 ` [PATCH v8 04/24] mm: Prepare for FAULT_FLAG_SPECULATIVE Laurent Dufour
2018-02-16 15:25 ` [PATCH v8 05/24] mm: Introduce pte_spinlock " Laurent Dufour
2018-02-16 15:25 ` [PATCH v8 06/24] mm: make pte_unmap_same compatible with SPF Laurent Dufour
2018-02-16 15:25 ` [PATCH v8 07/24] mm: VMA sequence count Laurent Dufour
2018-02-16 15:25 ` [PATCH v8 08/24] mm: Protect VMA modifications using " Laurent Dufour
2018-02-16 15:25 ` [PATCH v8 09/24] mm: protect mremap() against SPF hanlder Laurent Dufour
2018-02-16 15:25 ` [PATCH v8 10/24] mm: Protect SPF handler against anon_vma changes Laurent Dufour
2018-02-16 15:25 ` [PATCH v8 11/24] mm: Cache some VMA fields in the vm_fault structure Laurent Dufour
2018-02-16 15:25 ` Laurent Dufour [this message]
2018-02-16 15:25 ` [PATCH v8 13/24] mm: Introduce __lru_cache_add_active_or_unevictable Laurent Dufour
2018-02-16 15:25 ` [PATCH v8 14/24] mm: Introduce __maybe_mkwrite() Laurent Dufour
2018-02-16 15:25 ` [PATCH v8 15/24] mm: Introduce __vm_normal_page() Laurent Dufour
2018-02-16 15:25 ` [PATCH v8 16/24] mm: Introduce __page_add_new_anon_rmap() Laurent Dufour
2018-02-16 15:25 ` [PATCH v8 17/24] mm: Protect mm_rb tree with a rwlock Laurent Dufour
2018-02-16 15:25 ` [PATCH v8 18/24] mm: Provide speculative fault infrastructure Laurent Dufour
2018-02-26 17:16 ` Daniel Jordan
2018-03-05 10:50 ` Laurent Dufour
2018-02-16 15:25 ` [PATCH v8 19/24] mm: Adding speculative page fault failure trace events Laurent Dufour
2018-02-16 15:25 ` [PATCH v8 20/24] perf: Add a speculative page fault sw event Laurent Dufour
2018-02-16 15:25 ` [PATCH v8 21/24] perf tools: Add support for the SPF perf event Laurent Dufour
2018-02-16 15:25 ` [PATCH v8 22/24] mm: Speculative page fault handler return VMA Laurent Dufour
2018-03-29 2:26 ` Ganesh Mahendran
2018-03-29 3:06 ` Ganesh Mahendran
2018-03-29 7:50 ` Laurent Dufour
2018-05-02 8:10 ` Ganesh Mahendran
2018-02-16 15:25 ` [PATCH v8 23/24] x86/mm: Add speculative pagefault handling Laurent Dufour
2018-02-16 15:25 ` [PATCH v8 24/24] powerpc/mm: Add speculative page fault Laurent Dufour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518794738-4186-13-git-send-email-ldufour@linux.vnet.ibm.com \
--to=ldufour@linux.vnet.ibm.com \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=alexei.starovoitov@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=bsingharora@gmail.com \
--cc=daniel.m.jordan@oracle.com \
--cc=dave@stgolabs.net \
--cc=haren@linux.vnet.ibm.com \
--cc=hpa@zytor.com \
--cc=jack@suse.cz \
--cc=kemi.wang@intel.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=will.deacon@arm.com \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).