linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Javier González" <jg@lightnvm.io>
To: mb@lightnvm.io
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-nvme@lists.infradead.org,
	"Javier González" <javier@cnexlabs.com>
Subject: [PATCH 11/20] lightnvm: pblk: check for supported version
Date: Wed, 21 Feb 2018 10:26:49 +0100	[thread overview]
Message-ID: <1519205218-26994-12-git-send-email-javier@cnexlabs.com> (raw)
In-Reply-To: <1519205218-26994-1-git-send-email-javier@cnexlabs.com>

At this point, only 1.2 spec is supported, thus check for it. Also,
since device-side L2P is only supported in the 1.2 spec, make sure to
only check its value under 1.2.

Signed-off-by: Javier González <javier@cnexlabs.com>
---
 drivers/lightnvm/pblk-init.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
index 56b4afc27add..ec39800eea42 100644
--- a/drivers/lightnvm/pblk-init.c
+++ b/drivers/lightnvm/pblk-init.c
@@ -990,9 +990,15 @@ static void *pblk_init(struct nvm_tgt_dev *dev, struct gendisk *tdisk,
 	struct pblk *pblk;
 	int ret;
 
-	if (dev->geo.c.dom & NVM_RSP_L2P) {
+	if (geo->c.version != NVM_OCSSD_SPEC_12) {
+		pr_err("pblk: OCSSD version not supported (%u)\n",
+							geo->c.version);
+		return ERR_PTR(-EINVAL);
+	}
+
+	if (geo->c.version == NVM_OCSSD_SPEC_12 && geo->c.dom & NVM_RSP_L2P) {
 		pr_err("pblk: host-side L2P table not supported. (%x)\n",
-							dev->geo.c.dom);
+							geo->c.dom);
 		return ERR_PTR(-EINVAL);
 	}
 
-- 
2.7.4

  parent reply	other threads:[~2018-02-21  9:30 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-21  9:26 [PATCH V2 00/20] lightnvm: pblk: implement 2.0 support Javier González
2018-02-21  9:26 ` [PATCH 01/20] lightnvm: simplify geometry structure Javier González
2018-02-22  7:25   ` Matias Bjørling
2018-02-22  7:44     ` Javier Gonzalez
2018-02-22 12:22       ` Matias Bjørling
2018-02-22 14:13         ` Javier Gonzalez
2018-02-21  9:26 ` [PATCH 02/20] lightnvm: add controller capabilities to 2.0 Javier González
2018-02-22  7:26   ` Matias Bjørling
2018-02-21  9:26 ` [PATCH 03/20] lightnvm: fix capabilities for 2.0 sysfs Javier González
2018-02-22  7:28   ` Matias Bjørling
2018-02-22  7:47     ` Javier Gonzalez
2018-02-22  9:39       ` Matias Bjørling
2018-02-22 10:25         ` Javier Gonzalez
2018-02-22 11:10           ` Matias Bjørling
2018-02-22 11:12             ` Javier Gonzalez
2018-02-21  9:26 ` [PATCH 04/20] lightnvm: add minor version to generic geometry Javier González
2018-02-22  7:34   ` Matias Bjørling
2018-02-22  7:53     ` Javier González
2018-02-21  9:26 ` [PATCH 05/20] lightnvm: rename number of channels and luns Javier González
2018-02-21  9:26 ` [PATCH 06/20] lightnvm: add shorten OCSSD version in geo Javier González
2018-02-21  9:26 ` [PATCH 07/20] lightnvm: rename sect_* to sec_* Javier González
2018-02-22  7:43   ` Matias Bjørling
2018-02-21  9:26 ` [PATCH 08/20] lightnvm: complete geo structure with maxoc* Javier González
2018-02-22  7:45   ` Matias Bjørling
2018-02-22  7:55     ` Javier Gonzalez
2018-02-22  9:45       ` Matias Bjørling
2018-02-22  9:52         ` Javier Gonzalez
2018-02-22 10:00           ` Matias Bjørling
2018-02-22 10:03             ` Javier Gonzalez
2018-02-21  9:26 ` [PATCH 09/20] lightnvm: use generic identify structure Javier González
2018-02-22  7:47   ` Matias Bjørling
2018-02-22  7:49     ` Javier González
2018-02-22  9:41       ` Matias Bjørling
2018-02-21  9:26 ` [PATCH 10/20] lightnvm: pblk: rename ppaf* to addrf* Javier González
2018-02-22  7:47   ` Matias Bjørling
2018-02-21  9:26 ` Javier González [this message]
2018-02-22  7:48   ` [PATCH 11/20] lightnvm: pblk: check for supported version Matias Bjørling
2018-02-21  9:26 ` [PATCH 12/20] lightnvm: complete 2.0 values in sysfs Javier González
2018-02-21  9:26 ` [PATCH 13/20] lightnvm: add support for 2.0 address format Javier González
2018-02-22  9:24   ` Matias Bjørling
2018-02-21  9:26 ` [PATCH 14/20] lightnvm: make address conversions depend on generic device Javier González
2018-02-21  9:26 ` [PATCH 15/20] nvme: make nvme_get_log_ext available Javier González
2018-02-21  9:26 ` [PATCH 16/20] lightnvm: implement get log report chunk helpers Javier González
2018-02-21  9:26 ` [PATCH 17/20] lightnvm: define chunk states Javier González
2018-02-21  9:26 ` [PATCH 18/20] lightnvm: pblk: implement get log report chunk Javier González
2018-02-21  9:26 ` [PATCH 19/20] lightnvm: pblk: refactor init/exit sequences Javier González
2018-02-21  9:26 ` [PATCH 20/20] lightnvm: pblk: implement 2.0 support Javier González
2018-02-21 14:30   ` Javier González

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1519205218-26994-12-git-send-email-javier@cnexlabs.com \
    --to=jg@lightnvm.io \
    --cc=javier@cnexlabs.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=mb@lightnvm.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).