From: Martin Kaiser <martin@kaiser.cx>
To: Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: Martin Kaiser <martin@kaiser.cx>
Subject: [PATCH] ARM: mx35_3ds: remove unnecessary USB OTG init flag
Date: Wed, 21 Feb 2018 23:17:43 +0100 [thread overview]
Message-ID: <1519251463-12318-1-git-send-email-martin@kaiser.cx> (raw)
The platform-specific init function for the USB OTG port,
mx35_3ds_otg_init(), sets the MXC_EHCI_INTERNAL_PHY flag.
This flag is applicable only to the host port, not to the OTG port. It's
ignored by mx35_initialize_usb_hw() when the OTG port is initialized.
Remove the flag to make it clear what is actually configured.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
arch/arm/mach-imx/mach-mx35_3ds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-imx/mach-mx35_3ds.c b/arch/arm/mach-imx/mach-mx35_3ds.c
index 1c33a6c..f1963f2 100644
--- a/arch/arm/mach-imx/mach-mx35_3ds.c
+++ b/arch/arm/mach-imx/mach-mx35_3ds.c
@@ -407,7 +407,7 @@ static void __init imx35_3ds_init_mc13892(void)
static int mx35_3ds_otg_init(struct platform_device *pdev)
{
- return mx35_initialize_usb_hw(pdev->id, MXC_EHCI_INTERNAL_PHY);
+ return mx35_initialize_usb_hw(pdev->id, 0);
}
/* OTG config */
--
2.1.4
next reply other threads:[~2018-02-21 22:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 22:17 Martin Kaiser [this message]
2018-02-24 9:08 ` [PATCH] ARM: mx35_3ds: remove unnecessary USB OTG init flag Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519251463-12318-1-git-send-email-martin@kaiser.cx \
--to=martin@kaiser.cx \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).