* [PATCH] sparc64: Oracle DAX driver depends on SPARC64
@ 2018-02-26 23:21 Guenter Roeck
2018-03-18 15:54 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2018-02-26 23:21 UTC (permalink / raw)
To: David S . Miller; +Cc: sparclinux, linux-kernel, Guenter Roeck, Kees Cook
sparc:allmodconfig fails to build as follows.
ERROR: "mdesc_release" [drivers/sbus/char/oradax.ko] undefined!
ERROR: "sun4v_hvapi_register" [drivers/sbus/char/oradax.ko] undefined!
ERROR: "mdesc_get_property" [drivers/sbus/char/oradax.ko] undefined!
ERROR: "mdesc_node_by_name" [drivers/sbus/char/oradax.ko] undefined!
ERROR: "mdesc_grab" [drivers/sbus/char/oradax.ko] undefined!
ERROR: "sun4v_ccb_info" [drivers/sbus/char/oradax.ko] undefined!
ERROR: "sun4v_ccb_submit" [drivers/sbus/char/oradax.ko] undefined!
ERROR: "sun4v_ccb_kill" [drivers/sbus/char/oradax.ko] undefined!
The symbols are only available with SPARC64 builds, thus the driver
depends on it.
Fixes: dd0273284c74 ("sparc64: Oracle DAX driver")
Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/sbus/char/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/sbus/char/Kconfig b/drivers/sbus/char/Kconfig
index a785aa7660c3..bf3c5f735614 100644
--- a/drivers/sbus/char/Kconfig
+++ b/drivers/sbus/char/Kconfig
@@ -72,7 +72,8 @@ config DISPLAY7SEG
config ORACLE_DAX
tristate "Oracle Data Analytics Accelerator"
- default m if SPARC64
+ depends on SPARC64
+ default m
help
Driver for Oracle Data Analytics Accelerator, which is
a coprocessor that performs database operations in hardware.
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sparc64: Oracle DAX driver depends on SPARC64
2018-02-26 23:21 [PATCH] sparc64: Oracle DAX driver depends on SPARC64 Guenter Roeck
@ 2018-03-18 15:54 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-03-18 15:54 UTC (permalink / raw)
To: linux; +Cc: sparclinux, linux-kernel, keescook
From: Guenter Roeck <linux@roeck-us.net>
Date: Mon, 26 Feb 2018 15:21:18 -0800
> sparc:allmodconfig fails to build as follows.
>
> ERROR: "mdesc_release" [drivers/sbus/char/oradax.ko] undefined!
> ERROR: "sun4v_hvapi_register" [drivers/sbus/char/oradax.ko] undefined!
> ERROR: "mdesc_get_property" [drivers/sbus/char/oradax.ko] undefined!
> ERROR: "mdesc_node_by_name" [drivers/sbus/char/oradax.ko] undefined!
> ERROR: "mdesc_grab" [drivers/sbus/char/oradax.ko] undefined!
> ERROR: "sun4v_ccb_info" [drivers/sbus/char/oradax.ko] undefined!
> ERROR: "sun4v_ccb_submit" [drivers/sbus/char/oradax.ko] undefined!
> ERROR: "sun4v_ccb_kill" [drivers/sbus/char/oradax.ko] undefined!
>
> The symbols are only available with SPARC64 builds, thus the driver
> depends on it.
>
> Fixes: dd0273284c74 ("sparc64: Oracle DAX driver")
> Cc: Kees Cook <keescook@chromium.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-18 15:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-26 23:21 [PATCH] sparc64: Oracle DAX driver depends on SPARC64 Guenter Roeck
2018-03-18 15:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).