Re: [PATCH 1/1] x86: Fix Intel Edison module stuck reboot

* Re: [PATCH 1/1] x86: Fix Intel Edison module stuck reboot
       [not found] <CANoH8WgoPbhh+OS-HQD5uk3xbedrqHnwufJ9Bj4hSEuuTBkapw@mail.gmail.com>
@ 2018-02-22 17:33 ` Andy Shevchenko
  2018-02-27 10:07   ` Sebastian Panceac
  0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2018-02-22 17:33 UTC (permalink / raw)
  To: Sebastian Panceac; +Cc: Linux Kernel Mailing List, x86

On Thu, Feb 22, 2018 at 11:27 AM, Sebastian Panceac <sebastian@resin.io> wrote:
>
> When powering Intel Edison module with 3.3V, the "reboot" command makes the module stuck.
> If the module is powered at a greater voltage, like 4.4V(as the Edison Mini Breakout board does), reboot works OK.
> This patch fixes the reboot problem for Intel Edison powered at 3.3V.

Unfortunately it doesn't explain the root cause. OTOH it seems no one
has any means to find it, no documentation, no person responsible for
Edison firmware responsive.

At least what I would like to mention that this copies a behaviour of
official BSP for Edison, where RESET command applied by default (and
BOOT is enforced by user via kernel command line).

Perhaps someone can dig an internet to see what BOOT SCU command means.

Your patch is mangled. Can you use `git send-email` directly?

> Signed-off-by: Sebastian Panceac <sebastian@resin.io>
> ---
> arch/x86/platform/intel-mid/intel-mid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/platform/intel-mid/intel-mid.c b/arch/x86/platform/intel-mid/intel-mid.c
> index 12a2725..d2b2e9f 100644
> --- a/arch/x86/platform/intel-mid/intel-mid.c
> +++ b/arch/x86/platform/intel-mid/intel-mid.c
> @@ -79,7 +79,7 @@ static void intel_mid_power_off(void)
>
> static void intel_mid_reboot(void)
> {
> - intel_scu_ipc_simple_command(IPCMSG_COLD_BOOT, 0);
> + intel_scu_ipc_simple_command(IPCMSG_COLD_RESET, 0);
> }
>
> static unsigned long __init intel_mid_calibrate_tsc(void)
> --
> 2.7.4

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 6+ messages in thread