linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V2] lightnvm: pblk: remove unused variable
@ 2018-02-28 15:57 Javier González
  2018-02-28 15:57 ` [PATCH] " Javier González
  2018-03-01 10:07 ` [PATCH V2] " Matias Bjørling
  0 siblings, 2 replies; 5+ messages in thread
From: Javier González @ 2018-02-28 15:57 UTC (permalink / raw)
  To: mb; +Cc: linux-block, linux-kernel, Javier González

# Changes since V1:
 - Rebase on top of latest 2.0 changes


Javier González (1):
  lightnvm: pblk: remove unused variable

 drivers/lightnvm/pblk-core.c | 3 ---
 1 file changed, 3 deletions(-)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] lightnvm: pblk: remove unused variable
  2018-02-28 15:57 [PATCH V2] lightnvm: pblk: remove unused variable Javier González
@ 2018-02-28 15:57 ` Javier González
  2018-03-01 10:07 ` [PATCH V2] " Matias Bjørling
  1 sibling, 0 replies; 5+ messages in thread
From: Javier González @ 2018-02-28 15:57 UTC (permalink / raw)
  To: mb; +Cc: linux-block, linux-kernel, Javier González

Remove unused variable after a previous cleanup (a8112b631adb)

Signed-off-by: Javier González <javier@cnexlabs.com>
---
 drivers/lightnvm/pblk-core.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
index cd663855ee88..b85cdedb5f48 100644
--- a/drivers/lightnvm/pblk-core.c
+++ b/drivers/lightnvm/pblk-core.c
@@ -1082,7 +1082,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct pblk_line *line,
 	struct nvm_geo *geo = &dev->geo;
 	struct pblk_line_meta *lm = &pblk->lm;
 	struct pblk_line_mgmt *l_mg = &pblk->l_mg;
-	int nr_bb = 0;
 	u64 off;
 	int bit = -1;
 	int emeta_secs;
@@ -1098,8 +1097,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct pblk_line *line,
 		bitmap_or(line->map_bitmap, line->map_bitmap, l_mg->bb_aux,
 							lm->sec_per_line);
 		line->sec_in_line -= geo->clba;
-		if (bit >= lm->emeta_bb)
-			nr_bb++;
 	}
 
 	/* Mark smeta metadata sectors as bad sectors */
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH V2] lightnvm: pblk: remove unused variable
  2018-02-28 15:57 [PATCH V2] lightnvm: pblk: remove unused variable Javier González
  2018-02-28 15:57 ` [PATCH] " Javier González
@ 2018-03-01 10:07 ` Matias Bjørling
  2018-03-01 10:24   ` Javier González
  1 sibling, 1 reply; 5+ messages in thread
From: Matias Bjørling @ 2018-03-01 10:07 UTC (permalink / raw)
  To: Javier González; +Cc: linux-block, linux-kernel, Javier González

On 02/28/2018 04:57 PM, Javier González wrote:
> # Changes since V1:
>   - Rebase on top of latest 2.0 changes
> 
> 
> Javier González (1):
>    lightnvm: pblk: remove unused variable
> 
>   drivers/lightnvm/pblk-core.c | 3 ---
>   1 file changed, 3 deletions(-)
> 

Okay if I merge this with Hans' patch? It has not gone upstream yet.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH V2] lightnvm: pblk: remove unused variable
  2018-03-01 10:07 ` [PATCH V2] " Matias Bjørling
@ 2018-03-01 10:24   ` Javier González
  2018-03-01 18:43     ` Matias Bjørling
  0 siblings, 1 reply; 5+ messages in thread
From: Javier González @ 2018-03-01 10:24 UTC (permalink / raw)
  To: Matias Bjørling; +Cc: linux-block, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]



> On 1 Mar 2018, at 11.07, Matias Bjørling <mb@lightnvm.io> wrote:
> 
> On 02/28/2018 04:57 PM, Javier González wrote:
>> # Changes since V1:
>>  - Rebase on top of latest 2.0 changes
>> Javier González (1):
>>   lightnvm: pblk: remove unused variable
>>  drivers/lightnvm/pblk-core.c | 3 ---
>>  1 file changed, 3 deletions(-)
> 
> Okay if I merge this with Hans' patch? It has not gone upstream yet.

Of course!

Javier

[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH V2] lightnvm: pblk: remove unused variable
  2018-03-01 10:24   ` Javier González
@ 2018-03-01 18:43     ` Matias Bjørling
  0 siblings, 0 replies; 5+ messages in thread
From: Matias Bjørling @ 2018-03-01 18:43 UTC (permalink / raw)
  To: Javier González; +Cc: linux-block, linux-kernel

On 03/01/2018 11:24 AM, Javier González wrote:
> 
> 
>> On 1 Mar 2018, at 11.07, Matias Bjørling <mb@lightnvm.io> wrote:
>>
>> On 02/28/2018 04:57 PM, Javier González wrote:
>>> # Changes since V1:
>>>   - Rebase on top of latest 2.0 changes
>>> Javier González (1):
>>>    lightnvm: pblk: remove unused variable
>>>   drivers/lightnvm/pblk-core.c | 3 ---
>>>   1 file changed, 3 deletions(-)
>>
>> Okay if I merge this with Hans' patch? It has not gone upstream yet.
> 
> Of course!
> 

Thanks. Applied.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-03-01 18:43 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-28 15:57 [PATCH V2] lightnvm: pblk: remove unused variable Javier González
2018-02-28 15:57 ` [PATCH] " Javier González
2018-03-01 10:07 ` [PATCH V2] " Matias Bjørling
2018-03-01 10:24   ` Javier González
2018-03-01 18:43     ` Matias Bjørling

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).