linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: frowand.list@gmail.com
To: Rob Herring <robh+dt@kernel.org>, cpandya@codeaurora.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v4 0/2] of: cache phandle nodes to reduce cost of of_find_node_by_phandle()
Date: Wed, 28 Feb 2018 11:04:14 -0800	[thread overview]
Message-ID: <1519844656-16443-1-git-send-email-frowand.list@gmail.com> (raw)

From: Frank Rowand <frank.rowand@sony.com>

Create a cache of the nodes that contain a phandle property.  Use this
cache to find the node for a given phandle value instead of scanning
the devicetree to find the node.  If the phandle value is not found
in the cache, of_find_node_by_phandle() will fall back to the tree
scan algorithm.

Size and performance data is in patch 1/2 comments

Changes since v3:
  - of_populate_phandle_cache(): add check for failed memory allocation
  - add patch 2/2 into series instead of as a standalone patch that was
    dependent on patch 1/2 of this series

Changes since v2:
  - add mask to calculation of phandle cache entry
  - which results in better overhead reduction for devicetrees with
    phandle properties not allocated in the monotonically increasing
    range of 1..n
  - due to mask, number of entries in cache potentially increased to
    next power of two
  - minor fixes as suggested by reviewers
  - no longer using live_tree_max_phandle() so do not move it from
    drivers/of/resolver.c to drivers/of/base.c

Changes since v1:
  - change short description from
    of: cache phandle nodes to reduce cost of of_find_node_by_phandle()
  - rebase on v4.16-rc1
  - reorder new functions in base.c to avoid forward declaration
  - add locking around kfree(phandle_cache) for memory ordering
  - add explicit check for non-null of phandle_cache in
    of_find_node_by_phandle().  There is already a check for !handle,
    which prevents accessing a null phandle_cache, but that dependency
    is not obvious, so this check makes it more apparent.
  - do not free phandle_cache if modules are enabled, so that
    cached phandles will be available when modules are loaded



Frank Rowand (2):
  of: cache phandle nodes to reduce cost of of_find_node_by_phandle()
  of: add early boot allocation of of_find_node_by_phandle() cache

 drivers/of/base.c       | 119 ++++++++++++++++++++++++++++++++++++++++++++++--
 drivers/of/fdt.c        |   2 +
 drivers/of/of_private.h |   5 ++
 drivers/of/resolver.c   |   3 --
 4 files changed, 122 insertions(+), 7 deletions(-)

-- 
Frank Rowand <frank.rowand@sony.com>

             reply	other threads:[~2018-02-28 19:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-28 19:04 frowand.list [this message]
2018-02-28 19:04 ` [PATCH v4 1/2] of: cache phandle nodes to reduce cost of of_find_node_by_phandle() frowand.list
2018-02-28 19:31   ` Andy Shevchenko
2018-02-28 19:44     ` Frank Rowand
2018-02-28 20:19       ` Andy Shevchenko
2018-02-28 20:54         ` Rob Herring
2018-02-28 20:58         ` Frank Rowand
2018-02-28 19:04 ` [PATCH v4 2/2] of: add early boot allocation of of_find_node_by_phandle() cache frowand.list
2018-03-03  5:25   ` [of] b013aa45d2: kernel_BUG_at_arch/x86/mm/physaddr.c kernel test robot
2018-03-03  7:38   ` [PATCH v4 2/2] of: add early boot allocation of of_find_node_by_phandle() cache kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1519844656-16443-1-git-send-email-frowand.list@gmail.com \
    --to=frowand.list@gmail.com \
    --cc=cpandya@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).