From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031995AbeCAPYu (ORCPT ); Thu, 1 Mar 2018 10:24:50 -0500 Received: from smtp-fw-9101.amazon.com ([207.171.184.25]:53268 "EHLO smtp-fw-9101.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031977AbeCAPYq (ORCPT ); Thu, 1 Mar 2018 10:24:46 -0500 X-IronPort-AV: E=Sophos;i="5.47,408,1515456000"; d="scan'208";a="725186399" From: "Raslan, KarimAllah" To: "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "x86@kernel.org" CC: "hpa@zytor.com" , "jmattson@google.com" , "rkrcmar@redhat.com" , "tglx@linutronix.de" , "mingo@redhat.com" , "pbonzini@redhat.com" Subject: Re: [PATCH 00/10] KVM/X86: Handle guest memory that does not have a struct page Thread-Topic: [PATCH 00/10] KVM/X86: Handle guest memory that does not have a struct page Thread-Index: AQHTqzwO4mFZ4WE2jEyHcxNKmi0cSaO7jFUA Date: Thu, 1 Mar 2018 15:24:34 +0000 Message-ID: <1519917874.15908.41.camel@amazon.de> References: <1519235241-6500-1-git-send-email-karahmed@amazon.de> In-Reply-To: <1519235241-6500-1-git-send-email-karahmed@amazon.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.164.111] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id w21FPLdd030214 Jim/Paolo/Radim, Any complains about the current API? (introduced in 4/10) I have more patches on top and I would like to ensure that this is  agreed upon at least before sending more revisions/patches. Also 1, 2, and 3 should be a bit straight forward and does not use  this API. Thanks. On Wed, 2018-02-21 at 18:47 +0100, KarimAllah Ahmed wrote: > For the most part, KVM can handle guest memory that does not have a struct > page (i.e. not directly managed by the kernel). However, There are a few places > in the code, specially in the nested code, that does not support that. > > Patch 1, 2, and 3 avoid the mapping and unmapping all together and just > directly use kvm_guest_read and kvm_guest_write. > > Patch 4 introduces a new guest mapping interface that encapsulate all the > bioler plate code that is needed to map and unmap guest memory. It also > supports guest memory without "struct page". > > Patch 5, 6, 7, 8, 9, and 10 switch most of the offending code in VMX and hyperv > to use the new guest mapping API. > > This patch series is the first set of fixes. Handling SVM and APIC-access page > will be handled in a different patch series. > > KarimAllah Ahmed (10): > X86/nVMX: handle_vmon: Read 4 bytes from guest memory instead of > map->read->unmap sequence > X86/nVMX: handle_vmptrld: Copy the VMCS12 directly from guest memory > instead of map->copy->unmap sequence. > X86/nVMX: Update the PML table without mapping and unmapping the page > KVM: Introduce a new guest mapping API > KVM/nVMX: Use kvm_vcpu_map when mapping the L1 MSR bitmap > KVM/nVMX: Use kvm_vcpu_map when mapping the virtual APIC page > KVM/nVMX: Use kvm_vcpu_map when mapping the posted interrupt > descriptor table > KVM/X86: Use kvm_vcpu_map in emulator_cmpxchg_emulated > KVM/X86: hyperv: Use kvm_vcpu_map in synic_clear_sint_msg_pending > KVM/X86: hyperv: Use kvm_vcpu_map in synic_deliver_msg > > arch/x86/kvm/hyperv.c | 28 ++++----- > arch/x86/kvm/vmx.c | 144 +++++++++++++++-------------------------------- > arch/x86/kvm/x86.c | 13 ++--- > include/linux/kvm_host.h | 15 +++++ > virt/kvm/kvm_main.c | 50 ++++++++++++++++ > 5 files changed, 129 insertions(+), 121 deletions(-) > Amazon Development Center Germany GmbH Berlin - Dresden - Aachen main office: Krausenstr. 38, 10117 Berlin Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger Ust-ID: DE289237879 Eingetragen am Amtsgericht Charlottenburg HRB 149173 B