From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Hans de Goede <hdegoede@redhat.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] virt: vbox: Mark expected switch fall-through
Date: Tue, 26 Feb 2019 20:32:34 -0600 [thread overview]
Message-ID: <1519f96a-90d0-6c65-53d6-a6401f5fb979@embeddedor.com> (raw)
In-Reply-To: <0e90b0f5-41a3-1a46-daca-1f3f02b1c903@redhat.com>
On 2/26/19 3:04 PM, Hans de Goede wrote:
> Hi,
>
> On 26-02-19 20:23, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/virt/vboxguest/vboxguest_core.c: In function ‘vbg_core_ioctl’:
>> drivers/virt/vboxguest/vboxguest_core.c:1486:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> f32bit = true;
>> ~~~~~~~^~~~~~
>> drivers/virt/vboxguest/vboxguest_core.c:1489:2: note: here
>> case VBG_IOCTL_HGCM_CALL(0):
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> Notice that, in this particular case, the code comment is modified
>> in accordance with what GCC is expecting to find.
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Thank you the patch, patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
Thank you, Hans.
--
Gustavo
> Regards,
>
> Hans
>
>
>
>> ---
>> drivers/virt/vboxguest/vboxguest_core.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/virt/vboxguest/vboxguest_core.c b/drivers/virt/vboxguest/vboxguest_core.c
>> index 1475ed5ffcde..df7d09409efe 100644
>> --- a/drivers/virt/vboxguest/vboxguest_core.c
>> +++ b/drivers/virt/vboxguest/vboxguest_core.c
>> @@ -1484,8 +1484,8 @@ int vbg_core_ioctl(struct vbg_session *session, unsigned int req, void *data)
>> #ifdef CONFIG_COMPAT
>> case VBG_IOCTL_HGCM_CALL_32(0):
>> f32bit = true;
>> - /* Fall through */
>> #endif
>> + /* Fall through */
>> case VBG_IOCTL_HGCM_CALL(0):
>> return vbg_ioctl_hgcm_call(gdev, session, f32bit, data);
>> case VBG_IOCTL_LOG(0):
>>
prev parent reply other threads:[~2019-02-27 2:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 19:23 [PATCH] virt: vbox: Mark expected switch fall-through Gustavo A. R. Silva
2019-02-26 21:04 ` Hans de Goede
2019-02-27 2:32 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519f96a-90d0-6c65-53d6-a6401f5fb979@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).