From: Jens Axboe <axboe@kernel.dk>
To: Keith Busch <kbusch@kernel.org>
Cc: Linux regressions mailing list <regressions@lists.linux.dev>,
Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
michallinuxstuff@gmail.com
Subject: Re: [regression] Bug 217037 - cmb attributes missing from the nvme class under sysfs
Date: Fri, 17 Feb 2023 14:23:50 -0700 [thread overview]
Message-ID: <151a00d9-0ea2-eadb-72b4-fa8a2dd41bfc@kernel.dk> (raw)
In-Reply-To: <Y+5JdR02tlzD/TFS@kbusch-mbp>
On Thu, Feb 16, 2023 at 8:19 AM Keith Busch <kbusch@kernel.org> wrote:
>
> On Thu, Feb 16, 2023 at 10:28:55AM +0100, Linux regression tracking (Thorsten Leemhuis) wrote:
> > Hi, this is your Linux kernel regression tracker.
> >
> > I noticed a regression report in bugzilla.kernel.org. As many (most?)
> > kernel developer don't keep an eye on it, I decided to forward it by
> > mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=217037 :
> >
> > > michallinuxstuff@gmail.com 2023-02-14 14:16:26 UTC
> > >
> > > For the CMB-capable nvme ctrls, kernel was exposing couple of related attributes under the sysfs. E.g.
> > >
> > >
> > > # grep . /sys/class/nvme/nvme0/cmb*
> > > /sys/class/nvme/nvme0/cmb:cmbloc : x00000062
> > > /sys/class/nvme/nvme0/cmb:cmbsz : x0008021d
> > > /sys/class/nvme/nvme0/cmbloc:98
> > > /sys/class/nvme/nvme0/cmbsz:524829
>
> The breakage is that the attributes are decided before we've setup the cmb
> regions. I'll send a fix shortly.
Michael, have you tested this? It's queued up for inclusion, but I don't
see any evidence that this was tested.
--
Jens Axboe
next prev parent reply other threads:[~2023-02-17 21:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 9:28 [regression] Bug 217037 - cmb attributes missing from the nvme class under sysfs Linux regression tracking (Thorsten Leemhuis)
2023-02-16 15:19 ` Keith Busch
2023-02-17 21:23 ` Jens Axboe [this message]
2023-02-19 22:54 ` Michal Berger
2023-02-21 17:02 ` Keith Busch
2023-02-21 18:04 ` Michal Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=151a00d9-0ea2-eadb-72b4-fa8a2dd41bfc@kernel.dk \
--to=axboe@kernel.dk \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=michallinuxstuff@gmail.com \
--cc=regressions@lists.linux.dev \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).