From: Bjorn Helgaas <helgaas@kernel.org>
To: linux-pci@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org, Keith Busch <keith.busch@intel.com>,
Sinan Kaya <okaya@codeaurora.org>, Lukas Wunner <lukas@wunner.de>
Subject: [PATCH v1 0/9] PCI: Simplify PCIe port driver
Date: Wed, 07 Mar 2018 00:13:23 -0600 [thread overview]
Message-ID: <152040297576.240786.1532465558381209070.stgit@bhelgaas-glaptop.roam.corp.google.com> (raw)
This is an attempt to move a few things out of the port driver.
Patches 1-2 move a workaround for a BIOS PME issue from the port driver to
the PCI core, so it doesn't depend on CONFIG_PCIEPORTBUS.
Patch 3 extends that workaround so it works for Root Complex Event
Collectors. I haven't seen reports of this being a problem, but I think we
should handle Event Collector PMEs the same as Root Port PMEs.
Patch 4 disables the port driver completely for "pcie_ports=compat". We
used to register the driver, claim port devices, enable them, etc., as part
of supporting the above BIOS workaround.
Patch 5 removes a port driver link order dependency.
Patch 6 removes the unused VC service.
Patch 7 simplifies the _OSC code path by keeping more of the details in the
ACPI pci_root.c driver.
Patch 8 removes an unnecessary #include.
Patch 9 removes the "pcie_hp=nomsi" parameter. This was added to work
around an issue when shutting down devices, but a later patch fixed the
root cause, and I don't think we need such a specific parameter any more
(we still have "pci=nomsi").
---
Bjorn Helgaas (9):
PCI/PM: Move pcie_clear_root_pme_status() to core
PCI/PM: Clear PCIe PME Status bit in core, not PCIe port driver
PCI/PM: Clear PCIe PME Status bit for Root Complex Event Collectors
PCI/portdrv: Disable port driver in compat mode
PCI/portdrv: Remove pcie_port_bus_type link order dependency
PCI/portdrv: Remove unused PCIE_PORT_SERVICE_VC
PCI/portdrv: Simplify PCIe feature permission checking
PCI/portdrv: Remove unnecessary include of <linux/pci-aspm.h>
PCI/portdrv: Remove "pcie_hp=nomsi" kernel parameter
Documentation/admin-guide/kernel-parameters.txt | 4 -
drivers/acpi/pci_root.c | 13 +++-
drivers/pci/pci-driver.c | 60 ++++++++++++++++++
drivers/pci/pci.c | 9 +++
drivers/pci/pci.h | 1
drivers/pci/pcie/Makefile | 3 -
drivers/pci/pcie/portdrv.h | 27 --------
drivers/pci/pcie/portdrv_acpi.c | 2 -
drivers/pci/pcie/portdrv_bus.c | 56 -----------------
drivers/pci/pcie/portdrv_core.c | 77 ++++++++++-------------
drivers/pci/pcie/portdrv_pci.c | 40 +-----------
drivers/pci/probe.c | 10 +++
include/linux/pci.h | 3 +
include/linux/pcieport_if.h | 4 -
14 files changed, 131 insertions(+), 178 deletions(-)
delete mode 100644 drivers/pci/pcie/portdrv_bus.c
next reply other threads:[~2018-03-07 6:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 6:13 Bjorn Helgaas [this message]
2018-03-07 6:13 ` [PATCH v1 1/9] PCI/PM: Move pcie_clear_root_pme_status() to core Bjorn Helgaas
2018-03-07 10:24 ` Rafael J. Wysocki
2018-03-07 6:13 ` [PATCH v1 2/9] PCI/PM: Clear PCIe PME Status bit in core, not PCIe port driver Bjorn Helgaas
2018-03-07 10:27 ` Rafael J. Wysocki
2018-03-08 8:03 ` Lukas Wunner
2018-03-08 9:13 ` Rafael J. Wysocki
2018-03-07 6:13 ` [PATCH v1 3/9] PCI/PM: Clear PCIe PME Status bit for Root Complex Event Collectors Bjorn Helgaas
2018-03-07 10:27 ` Rafael J. Wysocki
2018-03-07 6:13 ` [PATCH v1 4/9] PCI/portdrv: Disable port driver in compat mode Bjorn Helgaas
2018-03-07 10:29 ` Rafael J. Wysocki
2018-03-07 6:13 ` [PATCH v1 5/9] PCI/portdrv: Remove pcie_port_bus_type link order dependency Bjorn Helgaas
2018-03-07 10:33 ` Rafael J. Wysocki
2018-03-07 6:13 ` [PATCH v1 6/9] PCI/portdrv: Remove unused PCIE_PORT_SERVICE_VC Bjorn Helgaas
2018-03-07 10:34 ` Rafael J. Wysocki
2018-03-07 6:14 ` [PATCH v1 7/9] PCI/portdrv: Simplify PCIe feature permission checking Bjorn Helgaas
2018-03-07 11:12 ` Rafael J. Wysocki
2018-03-07 6:14 ` [PATCH v1 8/9] PCI/portdrv: Remove unnecessary include of <linux/pci-aspm.h> Bjorn Helgaas
2018-03-07 11:12 ` Rafael J. Wysocki
2018-03-07 6:14 ` [PATCH v1 9/9] PCI/portdrv: Remove "pcie_hp=nomsi" kernel parameter Bjorn Helgaas
2018-03-07 11:13 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=152040297576.240786.1532465558381209070.stgit@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=okaya@codeaurora.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).