From: Stephen Boyd <swboyd@chromium.org>
To: Lina Iyer <ilina@codeaurora.org>,
andy.gross@linaro.org, david.brown@linaro.org,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org
Cc: rnayak@codeaurora.org, bjorn.andersson@linaro.org,
linux-kernel@vger.kernel.org, Lina Iyer <ilina@codeaurora.org>
Subject: Re: [PATCH v3 06/10] drivers: qcom: rpmh-rsc: allow invalidation of sleep/wake TCS
Date: Thu, 08 Mar 2018 12:40:09 -0800 [thread overview]
Message-ID: <152054160996.219802.12202813950978900157@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20180302164317.10554-7-ilina@codeaurora.org>
Quoting Lina Iyer (2018-03-02 08:43:13)
> diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c
> index 34e780d9670f..e9f5a1f387fd 100644
> --- a/drivers/soc/qcom/rpmh-rsc.c
> +++ b/drivers/soc/qcom/rpmh-rsc.c
> @@ -170,6 +170,52 @@ static struct tcs_group *get_tcs_of_type(struct rsc_drv *drv, int type)
> return tcs;
> }
>
> +/**
> + * rpmh_rsc_invalidate - Invalidate sleep and wake TCSes
> + *
> + * @drv: the mailbox controller
> + */
> +int rpmh_rsc_invalidate(struct rsc_drv *drv)
> +{
> + struct tcs_group *tcs;
> + int m, type, ret = 0;
> + int inv_types[] = { WAKE_TCS, SLEEP_TCS };
> + unsigned long drv_flags, flags;
> +
> + /* Lock the DRV and clear sleep and wake TCSes */
> + spin_lock_irqsave(&drv->drv_lock, drv_flags);
> + for (type = 0; type < ARRAY_SIZE(inv_types); type++) {
> + tcs = get_tcs_of_type(drv, inv_types[type]);
> + if (IS_ERR(tcs))
> + continue;
> +
> + spin_lock_irqsave(&tcs->tcs_lock, flags);
Should just be a spin_lock() because we already irq saved a few lines above.
> + if (bitmap_empty(tcs->slots, MAX_TCS_SLOTS)) {
> + spin_unlock_irqrestore(&tcs->tcs_lock, flags);
> + continue;
> + }
> +
> + /* Clear the enable register for each TCS of the type */
> + for (m = tcs->tcs_offset;
> + m < tcs->tcs_offset + tcs->num_tcs; m++) {
> + if (!tcs_is_free(drv, m)) {
> + spin_unlock_irqrestore(&tcs->tcs_lock, flags);
> + ret = -EAGAIN;
> + goto drv_unlock;
> + }
> + write_tcs_reg_sync(drv, RSC_DRV_CMD_ENABLE, m, 0, 0);
> + /* Mark the TCS slots as free */
> + bitmap_zero(tcs->slots, MAX_TCS_SLOTS);
> + }
> + spin_unlock_irqrestore(&tcs->tcs_lock, flags);
Maybe make another function called rpmh_tcs_invalidate(drv, enum TCS_FOO)
and put this logic inside it? And then change from a for loop to two
direct calls:
lock()
ret = rpmh_tcs_invalidate(drv, WAKE_TCS);
if (!ret)
ret = rpmh_tcs_invalidate(drv, SLEEP_TCS);
unlock()
next prev parent reply other threads:[~2018-03-08 20:40 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 16:43 [PATCH v3 00/10] drivers/qcom: add RPMH communication support Lina Iyer
2018-03-02 16:43 ` [PATCH v3 01/10] drivers: qcom: rpmh-rsc: add RPMH controller for QCOM SoCs Lina Iyer
2018-03-06 19:45 ` Stephen Boyd
2018-03-09 21:33 ` Lina Iyer
2018-03-09 21:37 ` Stephen Boyd
2018-03-02 16:43 ` [PATCH v3 02/10] dt-bindings: introduce RPMH RSC bindings for Qualcomm SoCs Lina Iyer
2018-03-06 22:30 ` Stephen Boyd
2018-03-07 20:54 ` Lina Iyer
2018-03-02 16:43 ` [PATCH v3 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE Lina Iyer
2018-03-06 5:38 ` kbuild test robot
2018-03-06 21:47 ` Steven Rostedt
2018-03-06 21:56 ` Lina Iyer
2018-03-06 22:05 ` Lina Iyer
2018-03-06 22:34 ` Steven Rostedt
2018-03-02 16:43 ` [PATCH v3 04/10] drivers: qcom: rpmh: add RPMH helper functions Lina Iyer
2018-03-08 18:57 ` Stephen Boyd
2018-03-08 21:37 ` Lina Iyer
2018-03-02 16:43 ` [PATCH v3 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS Lina Iyer
2018-03-08 19:41 ` Stephen Boyd
2018-03-08 23:58 ` Lina Iyer
2018-03-09 15:45 ` Lina Iyer
2018-03-02 16:43 ` [PATCH v3 06/10] drivers: qcom: rpmh-rsc: allow invalidation of sleep/wake TCS Lina Iyer
2018-03-08 20:40 ` Stephen Boyd [this message]
2018-03-09 16:41 ` Lina Iyer
2018-03-02 16:43 ` [PATCH v3 07/10] drivers: qcom: rpmh: cache sleep/wake state requests Lina Iyer
2018-03-05 20:44 ` Evan Green
2018-03-06 22:12 ` Lina Iyer
2018-03-02 16:43 ` [PATCH v3 08/10] drivers: qcom: rpmh: allow requests to be sent asynchronously Lina Iyer
2018-03-08 21:06 ` Stephen Boyd
2018-03-02 16:43 ` [PATCH v3 09/10] drivers: qcom: rpmh: add support for batch RPMH request Lina Iyer
2018-03-08 21:59 ` Stephen Boyd
2018-03-08 22:55 ` Lina Iyer
2018-03-16 17:00 ` Stephen Boyd
2018-03-26 15:30 ` Lina Iyer
2018-03-02 16:43 ` [PATCH v3 10/10] drivers: qcom: rpmh-rsc: allow active requests from wake TCS Lina Iyer
2018-03-08 20:47 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=152054160996.219802.12202813950978900157@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=rnayak@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).